From c1dae9205f7236b1d556dc3681133a121153a3ef Mon Sep 17 00:00:00 2001 From: Fraenkiman Date: Sat, 25 Feb 2023 19:49:14 +0100 Subject: [PATCH 1/4] for non-ASCII characters in the e-mail header fixes #209 Email notification is now sent when a new comment has been left and when the subject in the email header contains umlauts. --- comments.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/comments.php b/comments.php index b461d07..9fb1653 100644 --- a/comments.php +++ b/comments.php @@ -222,7 +222,8 @@ function commentform() { $fp_config ['general'] ['title'] ), $lang ['comments'] ['mail']); - @utils_mail($from_mail, "{$lang ['comments'] ['newcomment']} {$lang ['comments'] ['newcomment']} {$fp_config['general']['title']}", $mail); + // for non-ASCII characters in the e-mail header, use RFC 1342 — Encodes data with MIME base64 + @utils_mail($from_mail, "=?utf-8?B?" . base64_encode($lang ['comments'] ['newcomment']) . "?= =?utf-8?B?" . base64_encode($fp_config ['general'] ['title']) . "?=", $mail); } // if comment is valid, this redirect will clean the postdata From 8f28e293e68fce760b2052f3d559d9369860ebcd Mon Sep 17 00:00:00 2001 From: Fraenkiman Date: Sun, 26 Feb 2023 04:36:34 +0100 Subject: [PATCH 2/4] Update comments.php Splits the encrypted subject. The encrypted subject should not be longer than 76 characters. --- comments.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/comments.php b/comments.php index 9fb1653..511e0e2 100644 --- a/comments.php +++ b/comments.php @@ -222,8 +222,8 @@ function commentform() { $fp_config ['general'] ['title'] ), $lang ['comments'] ['mail']); - // for non-ASCII characters in the e-mail header, use RFC 1342 — Encodes data with MIME base64 - @utils_mail($from_mail, "=?utf-8?B?" . base64_encode($lang ['comments'] ['newcomment']) . "?= =?utf-8?B?" . base64_encode($fp_config ['general'] ['title']) . "?=", $mail); + // for non-ASCII characters in the e-mail header use RFC 1342 — Encodes data with MIME base64 and splits the encrypted subject + @utils_mail($from_mail, "=?utf-8?B?" . base64_encode($lang ['comments'] ['newcomment']) . "=?= =?utf-8?B?" . base64_encode($fp_config ['general'] ['title']) . "==?=", $mail); } // if comment is valid, this redirect will clean the postdata From 3ad8a38183dc76d3e4285545d54576949e9f09e6 Mon Sep 17 00:00:00 2001 From: Fraenkiman Date: Sun, 26 Feb 2023 05:01:59 +0100 Subject: [PATCH 3/4] Spaces inserted Spaces inserted so that they can be encrypted in the e-mail header --- fp-interface/lang/cs-cz/lang.comments.php | 2 +- fp-interface/lang/de-de/lang.comments.php | 2 +- fp-interface/lang/el-gr/lang.comments.php | 2 +- fp-interface/lang/en-us/lang.comments.php | 2 +- fp-interface/lang/es-es/lang.comments.php | 2 +- fp-interface/lang/fr-fr/lang.comments.php | 2 +- fp-interface/lang/it-it/lang.comments.php | 2 +- fp-interface/lang/ja-jp/lang.comments.php | 2 +- fp-interface/lang/nl-nl/lang.comments.php | 2 +- fp-interface/lang/pt-br/lang.comments.php | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fp-interface/lang/cs-cz/lang.comments.php b/fp-interface/lang/cs-cz/lang.comments.php index 53ad92d..d687941 100644 --- a/fp-interface/lang/cs-cz/lang.comments.php +++ b/fp-interface/lang/cs-cz/lang.comments.php @@ -11,6 +11,6 @@ S pozdravem %blogtitle% '; -$lang ['comments'] ['newcomment'] = 'Nový komentář k'; +$lang ['comments'] ['newcomment'] = 'Nový komentář k '; ?> diff --git a/fp-interface/lang/de-de/lang.comments.php b/fp-interface/lang/de-de/lang.comments.php index aaec3f1..eed2a6f 100644 --- a/fp-interface/lang/de-de/lang.comments.php +++ b/fp-interface/lang/de-de/lang.comments.php @@ -16,6 +16,6 @@ Automatisch generiert von, '; -$lang ['comments'] ['newcomment'] = 'Neuer Kommentar auf'; +$lang ['comments'] ['newcomment'] = 'Neuer Kommentar auf '; ?> diff --git a/fp-interface/lang/el-gr/lang.comments.php b/fp-interface/lang/el-gr/lang.comments.php index 7838214..d15cc34 100644 --- a/fp-interface/lang/el-gr/lang.comments.php +++ b/fp-interface/lang/el-gr/lang.comments.php @@ -16,6 +16,6 @@ $lang ['comments'] ['mail'] = 'Αγαπητέ/η %toname%, '; -$lang ['comments'] ['newcomment'] = 'νέο σχόλιο στο'; +$lang ['comments'] ['newcomment'] = 'νέο σχόλιο στο '; ?> diff --git a/fp-interface/lang/en-us/lang.comments.php b/fp-interface/lang/en-us/lang.comments.php index 4c25b9f..e54ecb6 100644 --- a/fp-interface/lang/en-us/lang.comments.php +++ b/fp-interface/lang/en-us/lang.comments.php @@ -16,6 +16,6 @@ All the best, '; -$lang ['comments'] ['newcomment'] = 'New comment on'; +$lang ['comments'] ['newcomment'] = 'New comment on '; ?> diff --git a/fp-interface/lang/es-es/lang.comments.php b/fp-interface/lang/es-es/lang.comments.php index d151203..21d4e4a 100644 --- a/fp-interface/lang/es-es/lang.comments.php +++ b/fp-interface/lang/es-es/lang.comments.php @@ -16,6 +16,6 @@ Todo lo mejor, '; -$lang ['comments'] ['newcomment'] = 'Nuevo comentario sobre'; +$lang ['comments'] ['newcomment'] = 'Nuevo comentario sobre '; ?> diff --git a/fp-interface/lang/fr-fr/lang.comments.php b/fp-interface/lang/fr-fr/lang.comments.php index b82c22a..d3eea62 100644 --- a/fp-interface/lang/fr-fr/lang.comments.php +++ b/fp-interface/lang/fr-fr/lang.comments.php @@ -16,6 +16,6 @@ Cordialement, '; -$lang ['comments'] ['newcomment'] = 'Nouveau commentaire sur'; +$lang ['comments'] ['newcomment'] = 'Nouveau commentaire sur '; ?> diff --git a/fp-interface/lang/it-it/lang.comments.php b/fp-interface/lang/it-it/lang.comments.php index 825f6ee..6990eb6 100644 --- a/fp-interface/lang/it-it/lang.comments.php +++ b/fp-interface/lang/it-it/lang.comments.php @@ -16,6 +16,6 @@ Saluti, '; -$lang ['comments'] ['newcomment'] = 'Nuovo commento su'; +$lang ['comments'] ['newcomment'] = 'Nuovo commento su '; ?> diff --git a/fp-interface/lang/ja-jp/lang.comments.php b/fp-interface/lang/ja-jp/lang.comments.php index e74b026..cc52838 100644 --- a/fp-interface/lang/ja-jp/lang.comments.php +++ b/fp-interface/lang/ja-jp/lang.comments.php @@ -19,6 +19,6 @@ $lang ['comments'] ['mail'] = '%toname% さま, '; -$lang ['comments'] ['newcomment'] = 'の新しいコメント'; +$lang ['comments'] ['newcomment'] = 'の新しいコメント '; ?> diff --git a/fp-interface/lang/nl-nl/lang.comments.php b/fp-interface/lang/nl-nl/lang.comments.php index 9a096aa..8297766 100644 --- a/fp-interface/lang/nl-nl/lang.comments.php +++ b/fp-interface/lang/nl-nl/lang.comments.php @@ -16,6 +16,6 @@ Groeten, '; -$lang ['comments'] ['newcomment'] = 'Nieuw commentaar op'; +$lang ['comments'] ['newcomment'] = 'Nieuw commentaar op '; ?> diff --git a/fp-interface/lang/pt-br/lang.comments.php b/fp-interface/lang/pt-br/lang.comments.php index 0fcbd7f..0bc86d4 100644 --- a/fp-interface/lang/pt-br/lang.comments.php +++ b/fp-interface/lang/pt-br/lang.comments.php @@ -17,6 +17,6 @@ Um abraço, '; -$lang ['comments'] ['newcomment'] = 'Novo comentário em'; +$lang ['comments'] ['newcomment'] = 'Novo comentário em '; ?> From 296470bd7bb70629ccc6541993bf4aa8d704b231 Mon Sep 17 00:00:00 2001 From: Fraenkiman Date: Mon, 27 Feb 2023 23:03:59 +0100 Subject: [PATCH 4/4] Update comments.php little correction --- comments.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/comments.php b/comments.php index 511e0e2..405920f 100644 --- a/comments.php +++ b/comments.php @@ -223,7 +223,7 @@ function commentform() { ), $lang ['comments'] ['mail']); // for non-ASCII characters in the e-mail header use RFC 1342 — Encodes data with MIME base64 and splits the encrypted subject - @utils_mail($from_mail, "=?utf-8?B?" . base64_encode($lang ['comments'] ['newcomment']) . "=?= =?utf-8?B?" . base64_encode($fp_config ['general'] ['title']) . "==?=", $mail); + @utils_mail($from_mail, '=?utf-8?B?' . base64_encode($lang ['comments'] ['newcomment']) . '=?= =?utf-8?B?' . base64_encode($fp_config ['general'] ['title']) . '==?=', $mail); } // if comment is valid, this redirect will clean the postdata