Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #19351 from timvandermeij/integration-tests-ink

Browse Source 
Centralize the editor selector definitions in the ink editor integration tests
This commit is contained in:
Jonas Jenwald 2025-01-20 10:23:08 +01:00 committed by GitHub
commit 01d542eee5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
test/integration/ink_editor_spec.mjs
View File

@ -305,16 +305,17 @@ describe("Ink Editor", () => {
await awaitPromise(clickHandle); await awaitPromise(clickHandle);
await commit(page); await commit(page);
await page.waitForSelector(getEditorSelector(0)); const editorSelector = getEditorSelector(0);
await page.waitForSelector(editorSelector);
await waitForSerialized(page, 1); await waitForSerialized(page, 1);
await page.waitForSelector(`${getEditorSelector(0)} button.delete`); await page.waitForSelector(`${editorSelector} button.delete`);
await page.click(`${getEditorSelector(0)} button.delete`); await page.click(`${editorSelector} button.delete`);
await waitForSerialized(page, 0); await waitForSerialized(page, 0);
await kbUndo(page); await kbUndo(page);
await waitForSerialized(page, 1); await waitForSerialized(page, 1);
await page.waitForSelector(getEditorSelector(0)); await page.waitForSelector(editorSelector);
}) })
); );
}); });
@ -348,11 +349,12 @@ describe("Ink Editor", () => {
await awaitPromise(clickHandle); await awaitPromise(clickHandle);
await commit(page); await commit(page);
await page.waitForSelector(getEditorSelector(0)); const editorSelector = getEditorSelector(0);
await page.waitForSelector(editorSelector);
await waitForSerialized(page, 1); await waitForSerialized(page, 1);
await page.waitForSelector(`${getEditorSelector(0)} button.delete`); await page.waitForSelector(`${editorSelector} button.delete`);
await page.click(`${getEditorSelector(0)} button.delete`); await page.click(`${editorSelector} button.delete`);
await waitForSerialized(page, 0); await waitForSerialized(page, 0);
const twoToFourteen = Array.from(new Array(13).keys(), n => n + 2); const twoToFourteen = Array.from(new Array(13).keys(), n => n + 2);
@ -370,7 +372,7 @@ describe("Ink Editor", () => {
await scrollIntoView(page, pageSelector); await scrollIntoView(page, pageSelector);
} }
await page.waitForSelector(getEditorSelector(0)); await page.waitForSelector(editorSelector);
}) })
); );
}); });
@ -404,11 +406,12 @@ describe("Ink Editor", () => {
await awaitPromise(clickHandle); await awaitPromise(clickHandle);
await commit(page); await commit(page);
await page.waitForSelector(getEditorSelector(0)); const editorSelector = getEditorSelector(0);
await page.waitForSelector(editorSelector);
await waitForSerialized(page, 1); await waitForSerialized(page, 1);
await page.waitForSelector(`${getEditorSelector(0)} button.delete`); await page.waitForSelector(`${editorSelector} button.delete`);
await page.click(`${getEditorSelector(0)} button.delete`); await page.click(`${editorSelector} button.delete`);
await waitForSerialized(page, 0); await waitForSerialized(page, 0);
const twoToOne = Array.from(new Array(13).keys(), n => n + 2).concat( const twoToOne = Array.from(new Array(13).keys(), n => n + 2).concat(
@ -421,7 +424,7 @@ describe("Ink Editor", () => {
await kbUndo(page); await kbUndo(page);
await waitForSerialized(page, 1); await waitForSerialized(page, 1);
await page.waitForSelector(getEditorSelector(0)); await page.waitForSelector(editorSelector);
}) })
); );
}); });
@ -941,7 +944,6 @@ describe("Ink Editor", () => {
await page.waitForSelector(getEditorSelector(1)); await page.waitForSelector(getEditorSelector(1));
await waitForSerialized(page, 1); await waitForSerialized(page, 1);
await page.waitForSelector(getEditorSelector(1));
await page.waitForSelector("#editorUndoBar", { hidden: true }); await page.waitForSelector("#editorUndoBar", { hidden: true });
}) })
); );