Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #18374 from calixteman/test_editor_visible

Browse Source 
Make sure the editor is visible before getting its rect
This commit is contained in:
Tim van der Meij 2024-07-04 11:14:27 +02:00 committed by GitHub
commit 03a0500dcf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/integration/test_utils.mjs
View File

@ -135,7 +135,7 @@ function getSelector(id) {
async function getRect(page, selector) { async function getRect(page, selector) {
// In Chrome something is wrong when serializing a `DomRect`, // In Chrome something is wrong when serializing a `DomRect`,
// so we extract the values and return them ourselves. // so we extract the values and return them ourselves.
await page.waitForSelector(selector); await page.waitForSelector(selector, { visible: true });
return page.$eval(selector, el => { return page.$eval(selector, el => {
const { x, y, width, height } = el.getBoundingClientRect(); const { x, y, width, height } = el.getBoundingClientRect();
return { x, y, width, height }; return { x, y, width, height };