Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #19646 from Snuffleupagus/dont-cache-MIN_TOUCH_DISTANCE_TO_PINCH

Browse Source 
Don't shadow the `TouchManager.prototype.MIN_TOUCH_DISTANCE_TO_PINCH` value
This commit is contained in:
Jonas Jenwald 2025-03-12 21:02:02 +01:00 committed by GitHub
commit 0cbb2b1d13
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/display/touch_manager.js
View File

@ -13,7 +13,6 @@
* limitations under the License. * limitations under the License.
*/ */
import { shadow } from "../shared/util.js";
import { stopEvent } from "./display_utils.js"; import { stopEvent } from "./display_utils.js";
class TouchManager { class TouchManager {
@ -65,6 +64,10 @@ class TouchManager {
}); });
} }
/**
* NOTE: Don't shadow this value since `devicePixelRatio` may change if the
* window resolution changes, e.g. if the viewer is moved to another monitor.
*/
get MIN_TOUCH_DISTANCE_TO_PINCH() { get MIN_TOUCH_DISTANCE_TO_PINCH() {
// The 35 is coming from: // The 35 is coming from:
// https://searchfox.org/mozilla-central/source/gfx/layers/apz/src/GestureEventListener.cpp#36 // https://searchfox.org/mozilla-central/source/gfx/layers/apz/src/GestureEventListener.cpp#36
@ -72,11 +75,7 @@ class TouchManager {
// The properties TouchEvent::screenX/Y are in screen CSS pixels: // The properties TouchEvent::screenX/Y are in screen CSS pixels:
// https://developer.mozilla.org/en-US/docs/Web/API/Touch/screenX#examples // https://developer.mozilla.org/en-US/docs/Web/API/Touch/screenX#examples
// MIN_TOUCH_DISTANCE_TO_PINCH is in CSS pixels. // MIN_TOUCH_DISTANCE_TO_PINCH is in CSS pixels.
return shadow( return 35 / (window.devicePixelRatio || 1);
this,
"MIN_TOUCH_DISTANCE_TO_PINCH",
35 / (window.devicePixelRatio || 1)
);
} }
#onTouchStart(evt) { #onTouchStart(evt) {