Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #18502 from Snuffleupagus/base_factory-shorter-errors

Browse Source 
Shorten the errors mentioning API parameters in `BaseCMapReaderFactory` and `BaseStandardFontDataFactory`
This commit is contained in:
Tim van der Meij 2024-07-27 20:48:39 +02:00 committed by GitHub
commit 0ed4521ad5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/display/base_factory.js
View File

@ -111,8 +111,7 @@ class BaseCMapReaderFactory {
async fetch({ name }) { async fetch({ name }) {
if (!this.baseUrl) { if (!this.baseUrl) {
throw new Error( throw new Error(
'The CMap "baseUrl" parameter must be specified, ensure that ' + "Ensure that the `cMapUrl` and `cMapPacked` API parameters are provided."
'the "cMapUrl" and "cMapPacked" API parameters are provided.'
); );
} }
if (!name) { if (!name) {
@ -149,8 +148,7 @@ class BaseStandardFontDataFactory {
async fetch({ filename }) { async fetch({ filename }) {
if (!this.baseUrl) { if (!this.baseUrl) {
throw new Error( throw new Error(
'The standard font "baseUrl" parameter must be specified, ensure that ' + "Ensure that the `standardFontDataUrl` API parameter is provided."
'the "standardFontDataUrl" API parameter is provided.'
); );
} }
if (!filename) { if (!filename) {

3
test/unit/cmap_spec.js
View File

@ -222,8 +222,7 @@ describe("cmap", function () {
} catch (reason) { } catch (reason) {
expect(reason instanceof Error).toEqual(true); expect(reason instanceof Error).toEqual(true);
expect(reason.message).toEqual( expect(reason.message).toEqual(
'The CMap "baseUrl" parameter must be specified, ensure that ' + "Ensure that the `cMapUrl` and `cMapPacked` API parameters are provided."
'the "cMapUrl" and "cMapPacked" API parameters are provided.'
); );
} }
}); });