Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #17825 from calixteman/bug1886964

Browse Source 
[Editor] Add a label to the highight floating button readable with NVDA (bug 1886964)
This commit is contained in:
calixteman 2024-03-23 18:30:42 +01:00 committed by GitHub
commit 14307c04dd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
l10n/en-US/viewer.ftl
View File

@ -318,8 +318,10 @@ pdfjs-editor-stamp-button-label = Add or edit images
pdfjs-editor-highlight-button = pdfjs-editor-highlight-button =
.title = Highlight .title = Highlight
pdfjs-editor-highlight-button-label = Highlight pdfjs-editor-highlight-button-label = Highlight
pdfjs-highlight-floating-button = pdfjs-highlight-floating-button1 =
.title = Highlight .title = Highlight
.aria-label = Highlight
pdfjs-highlight-floating-button-label = Highlight
## Remove button for the various kind of editor. ## Remove button for the various kind of editor.

6
src/display/editor/toolbar.js
View File

@ -202,7 +202,11 @@ class HighlightToolbar {
const button = document.createElement("button"); const button = document.createElement("button");
button.className = "highlightButton"; button.className = "highlightButton";
button.tabIndex = 0; button.tabIndex = 0;
button.setAttribute("data-l10n-id", `pdfjs-highlight-floating-button`); button.setAttribute("data-l10n-id", `pdfjs-highlight-floating-button1`);
const span = document.createElement("span");
button.append(span);
span.className = "visuallyHidden";
span.setAttribute("data-l10n-id", "pdfjs-highlight-floating-button-label");
button.addEventListener("contextmenu", noContextMenu); button.addEventListener("contextmenu", noContextMenu);
button.addEventListener("click", () => { button.addEventListener("click", () => {
this.#uiManager.highlightSelection("floating_button"); this.#uiManager.highlightSelection("floating_button");

2
web/annotation_editor_layer_builder.css
View File

@ -52,6 +52,8 @@
* for screen readers. */ * for screen readers. */
.visuallyHidden { .visuallyHidden {
position: absolute; position: absolute;
top: 0;
left: 0;
border: 0; border: 0;
margin: 0; margin: 0;
padding: 0; padding: 0;