Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Editor] Avoid to have the create alt-text button without a click listener

Browse Source 
The toggle button hasn't a click listener after we deleted and downloaded the model.
This commit is contained in:
Calixte Denizet 2024-08-02 11:05:51 +02:00
parent 4422e6fb3b
commit 271bd4d079
1 changed files with 3 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
web/new_alt_text_manager.js
View File

@ -468,8 +468,6 @@ class NewAltTextManager {
class ImageAltTextSettings { class ImageAltTextSettings {
#aiModelSettings; #aiModelSettings;
#boundOnClickCreateModel;
#createModelButton; #createModelButton;
#dialog; #dialog;
@ -504,17 +502,12 @@ class ImageAltTextSettings {
this.#overlayManager = overlayManager; this.#overlayManager = overlayManager;
this.#eventBus = eventBus; this.#eventBus = eventBus;
this.#mlManager = mlManager; this.#mlManager = mlManager;
this.#boundOnClickCreateModel = this.#togglePref.bind(
this,
"enableGuessAltText"
);
const { altTextLearnMoreUrl } = mlManager; const { altTextLearnMoreUrl } = mlManager;
if (altTextLearnMoreUrl) { if (altTextLearnMoreUrl) {
learnMore.href = altTextLearnMoreUrl; learnMore.href = altTextLearnMoreUrl;
} }
dialog.addEventListener("close", this.#close.bind(this));
dialog.addEventListener("contextmenu", noContextMenu); dialog.addEventListener("contextmenu", noContextMenu);
createModelButton.addEventListener("click", async e => { createModelButton.addEventListener("click", async e => {
@ -531,10 +524,7 @@ class ImageAltTextSettings {
await mlManager.deleteModel("altText"); await mlManager.deleteModel("altText");
aiModelSettings.classList.toggle("download", true); aiModelSettings.classList.toggle("download", true);
createModelButton.removeEventListener( createModelButton.disabled = true;
"click",
this.#boundOnClickCreateModel
);
createModelButton.setAttribute("aria-pressed", false); createModelButton.setAttribute("aria-pressed", false);
this.#setPref("enableGuessAltText", false); this.#setPref("enableGuessAltText", false);
this.#setPref("enableAltTextModelDownload", false); this.#setPref("enableAltTextModelDownload", false);
@ -554,10 +544,7 @@ class ImageAltTextSettings {
"data-l10n-id", "data-l10n-id",
"pdfjs-editor-alt-text-settings-download-model-button" "pdfjs-editor-alt-text-settings-download-model-button"
); );
createModelButton.addEventListener( createModelButton.disabled = false;
"click",
this.#boundOnClickCreateModel
);
createModelButton.setAttribute("aria-pressed", true); createModelButton.setAttribute("aria-pressed", true);
this.#setPref("enableGuessAltText", true); this.#setPref("enableGuessAltText", true);
mlManager.toggleService("altText", true); mlManager.toggleService("altText", true);
@ -585,12 +572,7 @@ class ImageAltTextSettings {
!enableAltTextModelDownload !enableAltTextModelDownload
); );
try { await this.#overlayManager.open(this.#dialog);
await this.#overlayManager.open(this.#dialog);
} catch (ex) {
this.#close();
throw ex;
}
} }
#togglePref(name, { target }) { #togglePref(name, { target }) {
@ -613,13 +595,6 @@ class ImageAltTextSettings {
this.#overlayManager.close(this.#dialog); this.#overlayManager.close(this.#dialog);
} }
} }
#close() {
this.#createModelButton.removeEventListener(
"click",
this.#boundOnClickCreateModel
);
}
} }
export { ImageAltTextSettings, NewAltTextManager }; export { ImageAltTextSettings, NewAltTextManager };