From 2979e23f3c9336ede2e5862aa2e721dc6f2942da Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 4 May 2025 12:34:30 +0200 Subject: [PATCH] Ensure that `XFAFactory.prototype.isValid` returns a boolean value Considering the name of the method, and how it's actually being used, you'd expect it to return a boolean value. Given how it's currently being used this inconsistency doesn't cause any issues, however we should still fix this. --- src/core/xfa/factory.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/xfa/factory.js b/src/core/xfa/factory.js index 7f9f4f28d..5dacfbb10 100644 --- a/src/core/xfa/factory.js +++ b/src/core/xfa/factory.js @@ -43,7 +43,7 @@ class XFAFactory { } isValid() { - return this.root && this.form; + return !!(this.root && this.form); } /**