From 2e80ef11a2ce387cf42d47e578aeea9fefd6fb5f Mon Sep 17 00:00:00 2001 From: MAZ <29178226+MAZ01001@users.noreply.github.com> Date: Tue, 29 Jul 2025 18:09:27 +0200 Subject: [PATCH] added tooltips to non-boolean elements --- extensions/chromium/options/options.js | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/extensions/chromium/options/options.js b/extensions/chromium/options/options.js index 0e25eb3bd..594bcf695 100644 --- a/extensions/chromium/options/options.js +++ b/extensions/chromium/options/options.js @@ -84,9 +84,16 @@ Promise.all([ // Unlike the renderBooleanPref branch, each preference handled by this // branch still needs its own template in options.html with // id="$prefName-template". - renderPreference = renderEnumPref(prefSchema.title, prefName); + renderPreference = renderEnumPref( + prefSchema.title, + prefSchema.description, + prefName + ); } else if (prefName === "defaultZoomValue") { - renderPreference = renderDefaultZoomValue(prefSchema.title); + renderPreference = renderDefaultZoomValue( + prefSchema.title, + prefSchema.description + ); } else { // Should NEVER be reached. Only happens if a new type of preference is // added to the storage manifest. @@ -162,7 +169,7 @@ function renderBooleanPref(shortDescription, description, prefName) { return renderPreference; } -function renderEnumPref(shortDescription, prefName) { +function renderEnumPref(shortDescription, description, prefName) { var wrapper = importTemplate(prefName + "-template"); var select = wrapper.querySelector("select"); select.onchange = function () { @@ -171,6 +178,7 @@ function renderEnumPref(shortDescription, prefName) { storageArea.set(pref); }; wrapper.querySelector("span").textContent = shortDescription; + wrapper.querySelector("label").title = description; document.getElementById("settings-boxes").append(wrapper); function renderPreference(value) { @@ -179,7 +187,7 @@ function renderEnumPref(shortDescription, prefName) { return renderPreference; } -function renderDefaultZoomValue(shortDescription) { +function renderDefaultZoomValue(shortDescription, description) { var wrapper = importTemplate("defaultZoomValue-template"); var select = wrapper.querySelector("select"); select.onchange = function () { @@ -188,6 +196,7 @@ function renderDefaultZoomValue(shortDescription) { }); }; wrapper.querySelector("span").textContent = shortDescription; + wrapper.querySelector("label").title = description; document.getElementById("settings-boxes").append(wrapper); function renderPreference(value) {