Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a basic navigator polyfill for older Node.js versions

Browse Source 
Modern Node.js versions now include a `navigator` implementation, with a few basic properties, that's actually enough for the PDF.js use-cases; please see https://nodejs.org/api/globals.html#navigator
Unfortunately we still support Node.js version `20`, hence we add a basic polyfill since that allows simplifying the code slightly.
This commit is contained in:
Jonas Jenwald 2025-04-28 12:52:42 +02:00
parent b47b248e15
commit 3d4e8bb17e
3 changed files with 23 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/display/node_utils.js
View File

@ -67,6 +67,13 @@ if (isNodeJS) {
warn("Cannot polyfill `Path2D`, rendering may be broken."); warn("Cannot polyfill `Path2D`, rendering may be broken.");
} }
} }
if (!globalThis.navigator?.language) {
globalThis.navigator = {
language: "en-US",
platform: "",
userAgent: "",
};
}
} }
} }

14
src/shared/util.js
View File

@ -643,12 +643,6 @@ class FeatureTest {
} }
static get platform() { static get platform() {
if (
(typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) ||
(typeof navigator !== "undefined" &&
typeof navigator?.platform === "string" &&
typeof navigator?.userAgent === "string")
) {
const { platform, userAgent } = navigator; const { platform, userAgent } = navigator;
return shadow(this, "platform", { return shadow(this, "platform", {
@ -661,14 +655,6 @@ class FeatureTest {
userAgent.includes("Firefox"), userAgent.includes("Firefox"),
}); });
} }
return shadow(this, "platform", {
isAndroid: false,
isLinux: false,
isMac: false,
isWindows: false,
isFirefox: false,
});
}
static get isCSSRoundSupported() { static get isCSSRoundSupported() {
return shadow( return shadow(

13
web/app_options.js
View File

@ -19,13 +19,16 @@ if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {
if ( if (
typeof PDFJSDev !== "undefined" && typeof PDFJSDev !== "undefined" &&
PDFJSDev.test("LIB") && PDFJSDev.test("LIB") &&
typeof navigator === "undefined" !globalThis.navigator?.language
) { ) {
globalThis.navigator = Object.create(null); globalThis.navigator = {
language: "en-US",
maxTouchPoints: 1,
platform: "",
userAgent: "",
};
} }
const userAgent = navigator.userAgent || ""; const { maxTouchPoints, platform, userAgent } = navigator;
const platform = navigator.platform || "";
const maxTouchPoints = navigator.maxTouchPoints || 1;
const isAndroid = /Android/.test(userAgent); const isAndroid = /Android/.test(userAgent);
const isIOS = const isIOS =