Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #20013 from calixteman/fix_annotation_tabindex

Browse Source 
Make annotations focusable just after the text layer
This commit is contained in:
calixteman 2025-06-19 14:09:27 +02:00 committed by GitHub
commit 5653458b51
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/display/annotation_layer.js
View File

@ -43,7 +43,6 @@ import { ColorConverters } from "../shared/scripting_utils.js";
import { DOMSVGFactory } from "./svg_factory.js"; import { DOMSVGFactory } from "./svg_factory.js";
import { XfaLayer } from "./xfa_layer.js"; import { XfaLayer } from "./xfa_layer.js";
const DEFAULT_TAB_INDEX = 1000;
const DEFAULT_FONT_SIZE = 9; const DEFAULT_FONT_SIZE = 9;
const GetElementsByNameSet = new WeakSet(); const GetElementsByNameSet = new WeakSet();
@ -263,7 +262,7 @@ class AnnotationElement {
const container = document.createElement("section"); const container = document.createElement("section");
container.setAttribute("data-annotation-id", data.id); container.setAttribute("data-annotation-id", data.id);
if (!(this instanceof WidgetAnnotationElement)) { if (!(this instanceof WidgetAnnotationElement)) {
container.tabIndex = DEFAULT_TAB_INDEX; container.tabIndex = 0;
} }
const { style } = container; const { style } = container;
@ -1293,7 +1292,7 @@ class TextWidgetAnnotationElement extends WidgetAnnotationElement {
element.disabled = this.data.readOnly; element.disabled = this.data.readOnly;
element.name = this.data.fieldName; element.name = this.data.fieldName;
element.tabIndex = DEFAULT_TAB_INDEX; element.tabIndex = 0;
this._setRequired(element, this.data.required); this._setRequired(element, this.data.required);
@ -1613,7 +1612,7 @@ class CheckboxWidgetAnnotationElement extends WidgetAnnotationElement {
element.setAttribute("checked", true); element.setAttribute("checked", true);
} }
element.setAttribute("exportValue", data.exportValue); element.setAttribute("exportValue", data.exportValue);
element.tabIndex = DEFAULT_TAB_INDEX; element.tabIndex = 0;
element.addEventListener("change", event => { element.addEventListener("change", event => {
const { name, checked } = event.target; const { name, checked } = event.target;
@ -1713,7 +1712,7 @@ class RadioButtonWidgetAnnotationElement extends WidgetAnnotationElement {
if (value) { if (value) {
element.setAttribute("checked", true); element.setAttribute("checked", true);
} }
element.tabIndex = DEFAULT_TAB_INDEX; element.tabIndex = 0;
element.addEventListener("change", event => { element.addEventListener("change", event => {
const { name, checked } = event.target; const { name, checked } = event.target;
@ -1820,7 +1819,7 @@ class ChoiceWidgetAnnotationElement extends WidgetAnnotationElement {
selectElement.disabled = this.data.readOnly; selectElement.disabled = this.data.readOnly;
this._setRequired(selectElement, this.data.required); this._setRequired(selectElement, this.data.required);
selectElement.name = this.data.fieldName; selectElement.name = this.data.fieldName;
selectElement.tabIndex = DEFAULT_TAB_INDEX; selectElement.tabIndex = 0;
let addAnEmptyEntry = this.data.combo && this.data.options.length > 0; let addAnEmptyEntry = this.data.combo && this.data.options.length > 0;