Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #18706 from Snuffleupagus/AltText-full-l10n-ids

Browse Source 
Use "full" localization ids in the `AltText` class (PR 18674 follow-up)
This commit is contained in:
Jonas Jenwald 2024-09-07 23:20:09 +02:00 committed by GitHub
commit 5d0c82cf05
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/display/editor/alt_text.js
View File

@ -38,11 +38,19 @@ class AltText {
#useNewAltTextFlow = false; #useNewAltTextFlow = false;
static #l10nNewButton = null;
static _l10nPromise = null; static _l10nPromise = null;
constructor(editor) { constructor(editor) {
this.#editor = editor; this.#editor = editor;
this.#useNewAltTextFlow = editor._uiManager.useNewAltTextFlow; this.#useNewAltTextFlow = editor._uiManager.useNewAltTextFlow;
AltText.#l10nNewButton ||= Object.freeze({
added: "pdfjs-editor-new-alt-text-added-button-label",
missing: "pdfjs-editor-new-alt-text-missing-button-label",
review: "pdfjs-editor-new-alt-text-to-review-button-label",
});
} }
static initialize(l10nPromise) { static initialize(l10nPromise) {
@ -55,9 +63,7 @@ class AltText {
let msg; let msg;
if (this.#useNewAltTextFlow) { if (this.#useNewAltTextFlow) {
altText.classList.add("new"); altText.classList.add("new");
msg = await AltText._l10nPromise.get( msg = await AltText._l10nPromise.get(AltText.#l10nNewButton.missing);
"pdfjs-editor-new-alt-text-missing-button-label"
);
} else { } else {
msg = await AltText._l10nPromise.get( msg = await AltText._l10nPromise.get(
"pdfjs-editor-alt-text-button-label" "pdfjs-editor-alt-text-button-label"
@ -235,16 +241,9 @@ class AltText {
} }
if (this.#useNewAltTextFlow) { if (this.#useNewAltTextFlow) {
// If we've an alt text, we get an "added".
// If we've a guessed text and the alt text has never been set, we get a
// "to-review" been set.
// Otherwise, we get a "missing".
const label = this.#label;
// TODO: Update the l10n keys to avoid this.
const type = label === "review" ? "to-review" : label;
button.classList.toggle("done", !!this.#altText); button.classList.toggle("done", !!this.#altText);
AltText._l10nPromise AltText._l10nPromise
.get(`pdfjs-editor-new-alt-text-${type}-button-label`) .get(AltText.#l10nNewButton[this.#label])
.then(msg => { .then(msg => {
button.setAttribute("aria-label", msg); button.setAttribute("aria-label", msg);
// We can't just use button.textContent here, because it would remove // We can't just use button.textContent here, because it would remove