Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix intermittent failure in the viewer alert tests

Browse Source 
It takes some time for the viewer alert to be updated after the editor
is committed, but the current tests don't await that and proceed too
fast to the viewer alert string assertion. This commit fixes the issue
by waiting for the expected viewer alert string to appear instead.
This commit is contained in:
Tim van der Meij 2025-07-18 20:39:44 +02:00
parent e4585c2452
commit 603fd2524a
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762
5 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/integration/freetext_editor_spec.mjs
View File

@ -111,8 +111,9 @@ describe("FreeText Editor", () => {
await waitForSelectedEditor(page, editorSelector); await waitForSelectedEditor(page, editorSelector);
await waitForStorageEntries(page, 1); await waitForStorageEntries(page, 1);
const alert = await page.$eval("#viewer-alert", el => el.textContent); await page.waitForFunction(
expect(alert).toEqual("Text added"); `document.getElementById("viewer-alert").textContent === "Text added"`
);
let content = await page.$eval(editorSelector, el => let content = await page.$eval(editorSelector, el =>
el.innerText.trimEnd() el.innerText.trimEnd()

5
test/integration/highlight_editor_spec.mjs
View File

@ -78,8 +78,9 @@ describe("Highlight Editor", () => {
await page.waitForSelector(`${getEditorSelector(0)}`); await page.waitForSelector(`${getEditorSelector(0)}`);
const alert = await page.$eval("#viewer-alert", el => el.textContent); await page.waitForFunction(
expect(alert).toEqual("Highlight added"); `document.getElementById("viewer-alert").textContent === "Highlight added"`
);
const oneToOne = Array.from(new Array(13).keys(), n => n + 2).concat( const oneToOne = Array.from(new Array(13).keys(), n => n + 2).concat(
Array.from(new Array(13).keys(), n => 13 - n) Array.from(new Array(13).keys(), n => 13 - n)

5
test/integration/ink_editor_spec.mjs
View File

@ -84,8 +84,9 @@ describe("Ink Editor", () => {
await commit(page); await commit(page);
} }
const alert = await page.$eval("#viewer-alert", el => el.textContent); await page.waitForFunction(
expect(alert).toEqual("Drawing added"); `document.getElementById("viewer-alert").textContent === "Drawing added"`
);
await clearAll(page); await clearAll(page);

5
test/integration/signature_editor_spec.mjs
View File

@ -181,8 +181,9 @@ describe("Signature Editor", () => {
{ visible: true } { visible: true }
); );
const alert = await page.$eval("#viewer-alert", el => el.textContent); await page.waitForFunction(
expect(alert).toEqual("Signature added"); `document.getElementById("viewer-alert").textContent === "Signature added"`
);
// Check the tooltip. // Check the tooltip.
await page.waitForSelector( await page.waitForSelector(

5
test/integration/stamp_editor_spec.mjs
View File

@ -125,8 +125,9 @@ describe("Stamp Editor", () => {
const editorSelector = getEditorSelector(0); const editorSelector = getEditorSelector(0);
await waitForImage(page, editorSelector); await waitForImage(page, editorSelector);
const alert = await page.$eval("#viewer-alert", el => el.textContent); await page.waitForFunction(
expect(alert).toEqual("Image added"); `document.getElementById("viewer-alert").textContent === "Image added"`
);
const { width } = await getEditorDimensions(page, editorSelector); const { width } = await getEditorDimensions(page, editorSelector);