Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Handle *empty* BigInt64Array/BigUint64Array in the isNumberArray helper

Browse Source 
The current checks would accidentally allow *empty* BigInt64Array/BigUint64Array, which we can fix by instead checking directly for those types.
This should be fine since those types are available in all environments that we support, see:
 - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt64Array#browser_compatibility
 - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigUint64Array#browser_compatibility
This commit is contained in:
Jonas Jenwald 2025-01-27 12:54:22 +01:00
parent 4f1078dc63
commit 6281a89778
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/core_utils.js
View File

@ -280,7 +280,7 @@ function isNumberArray(arr, len) {
// BigInt64Array/BigUint64Array types (their elements aren't "number"). // BigInt64Array/BigUint64Array types (their elements aren't "number").
return ( return (
ArrayBuffer.isView(arr) && ArrayBuffer.isView(arr) &&
(arr.length === 0 || typeof arr[0] === "number") && !(arr instanceof BigInt64Array || arr instanceof BigUint64Array) &&
(len === null || arr.length === len) (len === null || arr.length === len)
); );
} }