From 687c91d4e204f4102ca7ea4d11fe421a4f38e6e1 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Thu, 22 Aug 2024 14:38:56 +0200
Subject: [PATCH] Handle incomplete destinations in PDF documents where the
 viewport starts at non-zero coordinates (bug 1913617)

Hopefully this makes sense, since it doesn't appear to break "proper" PDF documents in my quick testing.
---
 web/pdf_viewer.js | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js
index 8ef7d25a9..80931902e 100644
--- a/web/pdf_viewer.js
+++ b/web/pdf_viewer.js
@@ -1491,15 +1491,14 @@ class PDFViewer {
       height = 0,
       widthScale,
       heightScale;
-    const changeOrientation = pageView.rotation % 180 !== 0;
-    const pageWidth =
-      (changeOrientation ? pageView.height : pageView.width) /
-      pageView.scale /
-      PixelsPerInch.PDF_TO_CSS_UNITS;
-    const pageHeight =
-      (changeOrientation ? pageView.width : pageView.height) /
-      pageView.scale /
-      PixelsPerInch.PDF_TO_CSS_UNITS;
+    // Utilize the viewport "end-points" rather than the effective width/height
+    // to avoid problems in PDF documents where the viewport starts at non-zero
+    // coordinates (fixes bug 1913617).
+    // NOTE: In the majority of PDF documents those values agree anyway.
+    const { viewBox } = pageView.viewport;
+    const changeOrientation = pageView.rotation % 180 !== 0,
+      pageWidth = changeOrientation ? viewBox[3] : viewBox[2],
+      pageHeight = changeOrientation ? viewBox[2] : viewBox[3];
     let scale = 0;
     switch (destArray[1].name) {
       case "XYZ":