Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Editor] Make sure the save checkbox isn't focusable when saving is disabled (bug 1952558)

Browse Source 
And fix the the width of the warning message when the limit of signatures has been reached:
in french the string is longer than the dialog's one.
This commit is contained in:
Calixte Denizet 2025-03-10 16:50:38 +01:00
parent 81baa16c8b
commit 69a2e5137d
4 changed files with 16 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/integration/signature_editor_spec.mjs
View File

@ -85,7 +85,7 @@ describe("Signature Editor", () => {
); );
await page.click("#addSignatureTypeInput"); await page.click("#addSignatureTypeInput");
await page.waitForSelector( await page.waitForSelector(
"#addSignatureSaveContainer[disabled=true]" "#addSignatureSaveContainer > input:disabled"
); );
let description = await page.$eval( let description = await page.$eval(
descriptionInputSelector, descriptionInputSelector,
@ -99,7 +99,7 @@ describe("Signature Editor", () => {
// The save button should be enabled now. // The save button should be enabled now.
await page.waitForSelector( await page.waitForSelector(
"#addSignatureSaveContainer:not([disabled])" "#addSignatureSaveContainer > input:not(:disabled)"
); );
await page.waitForSelector("#addSignatureSaveCheckbox[checked=true]"); await page.waitForSelector("#addSignatureSaveCheckbox[checked=true]");
@ -126,7 +126,7 @@ describe("Signature Editor", () => {
); );
// The save button should be disabled now. // The save button should be disabled now.
await page.waitForSelector( await page.waitForSelector(
"#addSignatureSaveContainer[disabled=true]" "#addSignatureSaveContainer > input:disabled"
); );
await page.waitForSelector(`${addButtonSelector}:disabled`); await page.waitForSelector(`${addButtonSelector}:disabled`);
@ -249,7 +249,7 @@ describe("Signature Editor", () => {
// The save button should be enabled now. // The save button should be enabled now.
await page.waitForSelector( await page.waitForSelector(
"#addSignatureSaveContainer:not([disabled])" "#addSignatureSaveContainer > input:not(:disabled)"
); );
await page.waitForSelector("#addSignatureSaveCheckbox[checked=true]"); await page.waitForSelector("#addSignatureSaveCheckbox[checked=true]");
@ -305,7 +305,7 @@ describe("Signature Editor", () => {
// The save button should be enabled now. // The save button should be enabled now.
await page.waitForSelector( await page.waitForSelector(
"#addSignatureSaveContainer:not([disabled])" "#addSignatureSaveContainer > input:not(:disabled)"
); );
await page.waitForSelector("#addSignatureSaveCheckbox[checked=true]"); await page.waitForSelector("#addSignatureSaveCheckbox[checked=true]");

14
web/signature_manager.css
View File

@ -595,12 +595,16 @@
#addSignatureSaveContainer { #addSignatureSaveContainer {
display: grid; display: grid;
grid-template-columns: max-content max-content; grid-template-columns: max-content auto;
gap: 4px; gap: 4px;
width: 100%; width: 100%;
> input { > input {
margin: 0; margin: 0;
&:disabled + label {
opacity: 0.4;
}
} }
> label { > label {
@ -617,14 +621,6 @@
color: var(--save-warning-color); color: var(--save-warning-color);
font-size: 11px; font-size: 11px;
} }
&:is([disabled], .fullStorage) {
pointer-events: none;
> :not(#addSignatureSaveWarning) {
opacity: 0.4;
}
}
} }
} }
} }

10
web/signature_manager.js
View File

@ -322,12 +322,10 @@ class SignatureManager {
} }
#disableButtons(value) { #disableButtons(value) {
this.#clearButton.disabled = this.#addButton.disabled = !value; this.#saveCheckbox.disabled =
if (value) { this.#clearButton.disabled =
this.#saveContainer.removeAttribute("disabled"); this.#addButton.disabled =
} else { !value;
this.#saveContainer.setAttribute("disabled", true);
}
} }
#initTypeTab(reset) { #initTypeTab(reset) {

4
web/viewer.html
View File

@ -727,7 +727,7 @@ See https://github.com/adobe-type-tools/cmap-resources
<input id="addSignatureFilePicker" type="file"></input> <input id="addSignatureFilePicker" type="file"></input>
</div> </div>
</div> </div>
<div id="addSignatureControls" disabled> <div id="addSignatureControls">
<div id="horizontalContainer"> <div id="horizontalContainer">
<div id="addSignatureDescriptionContainer"> <div id="addSignatureDescriptionContainer">
<label for="addSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label">Description (alt text)</span></label> <label for="addSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label">Description (alt text)</span></label>
@ -739,7 +739,7 @@ See https://github.com/adobe-type-tools/cmap-resources
<button id="clearSignatureButton" type="button" data-l10n-id="pdfjs-editor-add-signature-clear-button" tabindex="0"><span data-l10n-id="pdfjs-editor-add-signature-clear-button-label">Clear signature</span></button> <button id="clearSignatureButton" type="button" data-l10n-id="pdfjs-editor-add-signature-clear-button" tabindex="0"><span data-l10n-id="pdfjs-editor-add-signature-clear-button-label">Clear signature</span></button>
</div> </div>
<div id="addSignatureSaveContainer"> <div id="addSignatureSaveContainer">
<input type="checkbox" id="addSignatureSaveCheckbox" checked="true" tabindex="0"></input> <input type="checkbox" id="addSignatureSaveCheckbox" checked="true"></input>
<label for="addSignatureSaveCheckbox" data-l10n-id="pdfjs-editor-add-signature-save-checkbox">Save signature</label> <label for="addSignatureSaveCheckbox" data-l10n-id="pdfjs-editor-add-signature-save-checkbox">Save signature</label>
<span></span> <span></span>
<span id="addSignatureSaveWarning" data-l10n-id="pdfjs-editor-add-signature-save-warning-message">You’ve reached the limit of 5 saved signatures. Remove one to save more.</span> <span id="addSignatureSaveWarning" data-l10n-id="pdfjs-editor-add-signature-save-warning-message">You’ve reached the limit of 5 saved signatures. Remove one to save more.</span>