Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Editor] Set an aria-description for an added signature (bug 1956513)

Browse Source 
NVDA behaves differently depending if the user is hovering or focusing an added signature.
An aria-description is read in both cases while an aria-label is not.
This commit is contained in:
Calixte Denizet 2025-03-27 18:14:02 +01:00
parent 2da54ffb59
commit 7d8c64b2ff
3 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
l10n/en-US/viewer.ftl
View File

@ -332,8 +332,13 @@ pdfjs-editor-highlight-editor =
# “Drawing” is a noun, the string is used on the editor for drawings. # “Drawing” is a noun, the string is used on the editor for drawings.
pdfjs-editor-ink-editor = pdfjs-editor-ink-editor =
.aria-label = Drawing editor .aria-label = Drawing editor
pdfjs-editor-signature-editor =
.aria-label = Signature editor # Used when a signature editor is selected/hovered.
# Variables:
# $description (String) - a string describing/labeling the signature.
pdfjs-editor-signature-editor1 =
.aria-description = Signature editor: { $description }
pdfjs-editor-stamp-editor = pdfjs-editor-stamp-editor =
.aria-label = Image editor .aria-label = Image editor

17
src/display/editor/signature.js
View File

@ -79,7 +79,7 @@ class SignatureEditor extends DrawingEditor {
this._willKeepAspectRatio = true; this._willKeepAspectRatio = true;
this.#signatureData = params.signatureData || null; this.#signatureData = params.signatureData || null;
this.#description = null; this.#description = null;
this.defaultL10nId = "pdfjs-editor-signature-editor"; this.defaultL10nId = "pdfjs-editor-signature-editor1";
} }
/** @inheritdoc */ /** @inheritdoc */
@ -158,6 +158,13 @@ class SignatureEditor extends DrawingEditor {
super.render(); super.render();
if (typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL")) {
// TODO: remove this check once
// https://github.com/projectfluent/fluent.js/pull/640
// is merged and released.
this.div.setAttribute("data-l10n-attrs", "aria-description");
}
if (this._drawId === null) { if (this._drawId === null) {
if (this.#signatureData) { if (this.#signatureData) {
const { const {
@ -183,6 +190,12 @@ class SignatureEditor extends DrawingEditor {
}); });
this.addSignature(outline, heightInPage, description, uuid); this.addSignature(outline, heightInPage, description, uuid);
} else { } else {
// Avoid Firefox crashing (with a local build) because the description
// parameter is missing.
this.div.setAttribute(
"data-l10n-args",
JSON.stringify({ description: "" })
);
this.div.hidden = true; this.div.hidden = true;
this._uiManager.getSignature(this); this._uiManager.getSignature(this);
} }
@ -259,7 +272,7 @@ class SignatureEditor extends DrawingEditor {
const { outline } = (this.#signatureData = data); const { outline } = (this.#signatureData = data);
this.#isExtracted = outline instanceof ContourDrawOutline; this.#isExtracted = outline instanceof ContourDrawOutline;
this.#description = description; this.#description = description;
this.div.setAttribute("aria-description", description); this.div.setAttribute("data-l10n-args", JSON.stringify({ description }));
let drawingOptions; let drawingOptions;
if (this.#isExtracted) { if (this.#isExtracted) {
drawingOptions = SignatureEditor.getDefaultDrawingOptions(); drawingOptions = SignatureEditor.getDefaultDrawingOptions();

4
test/integration/signature_editor_spec.mjs
View File

@ -184,9 +184,9 @@ describe("Signature Editor", () => {
`.altText.editDescription[title="Hello World"]` `.altText.editDescription[title="Hello World"]`
); );
// Check the aria label. // Check the aria description.
await page.waitForSelector( await page.waitForSelector(
`${editorSelector}[aria-description="Hello World"]` `${editorSelector}[aria-description="Signature editor: \u2068Hello World\u2069"]`
); );
// Edit the description. // Edit the description.