Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #20311 from calixteman/fix_focus_comment_button

Browse Source 
[Editor] Give the focus to the comment button after editing in reading mode
This commit is contained in:
calixteman 2025-09-26 18:24:32 +02:00 committed by GitHub
commit 91384738f8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/display/annotation_layer.js
View File

@ -2545,6 +2545,12 @@ class PopupElement {
return this.#parent._commentManager.makeCommentColor(color, opacity);
}
focusCommentButton() {
setTimeout(() => {
this.#commentButton?.focus();
}, 0);
}
getData() {
const { richText, color, opacity, creationDate, modificationDate } =
this.#firstElement.commentData;

62
test/integration/comment_spec.mjs
View File

@ -376,6 +376,68 @@ describe("Comment", () => {
});
});
describe("Focused element after editing in reading mode", () => {
let pages;
beforeEach(async () => {
pages = await loadAndWait(
"comments.pdf",
".annotationLayer",
"page-width",
null,
{ enableComment: true }
);
});
afterEach(async () => {
await closePages(pages);
});
it("must check that the focus is moved on the comment button", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
const commentButtonSelector = `[data-annotation-id="612R"] + button.annotationCommentButton`;
await waitAndClick(page, commentButtonSelector);
const commentPopupSelector = "#commentPopup";
const editButtonSelector = `${commentPopupSelector} button.commentPopupEdit`;
await waitAndClick(page, editButtonSelector);
await page.waitForSelector("#commentManagerCancelButton", {
visible: true,
});
let handle = await createPromise(page, resolve => {
document
.querySelector(
`[data-annotation-id="612R"] + button.annotationCommentButton`
)
.addEventListener("focus", resolve, { once: true });
});
await page.click("#commentManagerCancelButton");
await awaitPromise(handle);
await waitAndClick(page, commentButtonSelector);
await waitAndClick(page, editButtonSelector);
const textInputSelector = "#commentManagerTextInput";
await page.waitForSelector(textInputSelector, {
visible: true,
});
await page.type(textInputSelector, "Hello world!");
handle = await createPromise(page, resolve => {
document
.querySelector(
`[data-annotation-id="612R"] + button.annotationCommentButton`
)
.addEventListener("focus", resolve, { once: true });
});
await page.click("#commentManagerSaveButton");
await awaitPromise(handle);
})
);
});
});
describe("Comment sidebar", () => {
let pages;