Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increase the rendering quality of the detail view (bug 1991482)

Browse Source 
But keep a lower quality when enableOptimizedPartialRendering is true because we need to compensate the time
used to compute the bboxes and since subsequent rendering are faster it's more acceptable to see
a lower quality image for few tenths of seconds.
This commit is contained in:
Calixte Denizet 2025-10-01 16:33:09 +02:00
parent 042e821bec
commit 91e2f6c400
4 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/integration/viewer_spec.mjs
View File

@ -364,16 +364,12 @@ describe("PDF viewer", () => {
.toBeLessThan(originalCanvasSize * factor ** 2); .toBeLessThan(originalCanvasSize * factor ** 2);
expect(canvasSize) expect(canvasSize)
.withContext(`In ${browserName}, <= MAX_CANVAS_PIXELS / 100`) .withContext(`In ${browserName}, <= MAX_CANVAS_PIXELS / 4`)
.toBeLessThanOrEqual(MAX_CANVAS_PIXELS.get(browserName) / 100); .toBeLessThanOrEqual(MAX_CANVAS_PIXELS.get(browserName) / 4);
expect(canvasSize) expect(canvasSize)
.withContext( .withContext(`In ${browserName}, > MAX_CANVAS_PIXELS / 4 * 0.95`)
`In ${browserName}, > MAX_CANVAS_PIXELS / 100 * 0.95` .toBeGreaterThan((MAX_CANVAS_PIXELS.get(browserName) / 4) * 0.95);
)
.toBeGreaterThan(
(MAX_CANVAS_PIXELS.get(browserName) / 100) * 0.95
);
}) })
); );
}); });
@ -570,10 +566,10 @@ describe("PDF viewer", () => {
.toBe(2); .toBe(2);
expect(after[0].width) expect(after[0].width)
.withContext(`In ${browserName}`) .withContext(`In ${browserName}`)
.toBe(Math.floor(58.2 * pixelRatio)); .toBe(Math.floor(291 * pixelRatio));
expect(after[0].height) expect(after[0].height)
.withContext(`In ${browserName}`) .withContext(`In ${browserName}`)
.toBe(Math.floor(82.3 * pixelRatio)); .toBe(Math.floor(411.5 * pixelRatio));
// The dimensions of the detail canvas are capped to 800x600 but // The dimensions of the detail canvas are capped to 800x600 but
// it depends on the visible area which depends itself of the // it depends on the visible area which depends itself of the

5
web/pdf_page_detail_view.js
View File

@ -267,7 +267,10 @@ class PDFPageDetailView extends BasePDFPageView {
canvasWrapper.prepend(newCanvas); canvasWrapper.prepend(newCanvas);
} }
}, hideUntilComplete); }, hideUntilComplete);
canvas.setAttribute("aria-hidden", "true"); canvas.ariaHidden = true;
if (this.enableOptimizedPartialRendering) {
canvas.className = "detailView";
}
const { width, height } = viewport; const { width, height } = viewport;

8
web/pdf_page_view.js
View File

@ -804,8 +804,12 @@ class PDFPageView extends BasePDFPageView {
if (this.#needsRestrictedScaling && this.enableDetailCanvas) { if (this.#needsRestrictedScaling && this.enableDetailCanvas) {
// If we are going to have a high-res detail view, further reduce // If we are going to have a high-res detail view, further reduce
// the canvas resolution to improve rendering performance. // the canvas resolution to improve rendering performance.
outputScale.sx /= 10; // When enableOptimizedPartialRendering is enabled the factor can be
outputScale.sy /= 10; // higher since less data will be rendered and it's more acceptable to
// have a lower quality (the canvas is exposed less time to the user).
const factor = this.enableOptimizedPartialRendering ? 4 : 2;
outputScale.sx /= factor;
outputScale.sy /= factor;
} }
} }
} }

4
web/pdf_viewer.css
View File

@ -99,6 +99,10 @@
.structTree { .structTree {
contain: strict; contain: strict;
} }
&.detailView {
image-rendering: pixelated;
}
} }
} }
} }