Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Be sure to consume responses in case of error in downloading test files (issue 19580)

Browse Source 
As mentioned in https://nodejs.org/docs/latest-v20.x/api/http.html#httpgeturl-options-callback
if a request results in an error, you still need to consume the data, or call
`response.resume()`, or your code will hang waiting for the request to close.
This commit is contained in:
David Huggins-Daines 2025-02-28 11:25:52 -05:00
parent 6e1cfa20d1
commit 962f972aea
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/downloadutils.mjs
View File

@ -42,6 +42,7 @@ function downloadFile(file, url, redirects = 0) {
.get(url, async function (response) { .get(url, async function (response) {
if ([301, 302, 307, 308].includes(response.statusCode)) { if ([301, 302, 307, 308].includes(response.statusCode)) {
if (redirects > 10) { if (redirects > 10) {
response.resume();
reject(new Error("Too many redirects")); reject(new Error("Too many redirects"));
return; return;
} }
@ -50,12 +51,14 @@ function downloadFile(file, url, redirects = 0) {
await downloadFile(file, redirectTo, ++redirects); await downloadFile(file, redirectTo, ++redirects);
resolve(); resolve();
} catch (ex) { } catch (ex) {
response.resume();
reject(ex); reject(ex);
} }
return; return;
} }
if (response.statusCode !== 200) { if (response.statusCode !== 200) {
response.resume();
reject(new Error(`HTTP ${response.statusCode}`)); reject(new Error(`HTTP ${response.statusCode}`));
return; return;
} }