Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Editor] Make sure the color picker has the right color when pasting an editor

Browse Source
This commit is contained in:
Calixte Denizet 2025-10-17 19:37:05 +02:00
parent 928a758811
commit 97fec3ab81
2 changed files with 54 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/display/editor/color_picker.js
View File

@ -334,10 +334,10 @@ class BasicColorPicker {
if (this.#input) {
return this.#input;
}
const { editorType, colorType, colorValue } = this.#editor;
const { editorType, colorType, color } = this.#editor;
const input = (this.#input = document.createElement("input"));
input.type = "color";
input.value = colorValue || "#000000";
input.value = color || "#000000";
input.className = "basicColorPicker";
input.tabIndex = 0;
input.setAttribute("data-l10n-id", BasicColorPicker.#l10nColor[editorType]);

52
test/integration/freetext_editor_spec.mjs
View File

@ -181,6 +181,58 @@ describe("FreeText Editor", () => {
}
});
it("must copy/paste and check color", async () => {
// Run sequentially to avoid clipboard issues.
for (const [browserName, page] of pages) {
await switchToFreeText(page);
const rect = await getRect(page, ".annotationEditorLayer");
const firstEditorSelector = getEditorSelector(0);
const data = "Hello PDF.js World !!";
await page.mouse.click(rect.x + 100, rect.y + 100);
await page.waitForSelector(firstEditorSelector, { visible: true });
await page.type(`${firstEditorSelector} .internal`, data);
await commit(page);
await waitForStorageEntries(page, 1);
await page.evaluate(() => {
window.PDFViewerApplication.eventBus.dispatch(
"switchannotationeditorparams",
{
source: null,
type: window.pdfjsLib.AnnotationEditorParamsType.FREETEXT_COLOR,
value: "#FF0000",
}
);
});
await selectEditor(page, firstEditorSelector);
await copy(page);
await paste(page);
const secondEditorSelector = getEditorSelector(1);
await page.waitForSelector(secondEditorSelector, { visible: true });
await waitForStorageEntries(page, 2);
const color = await page.$eval(
`${secondEditorSelector} .internal`,
el => getComputedStyle(el).color
);
expect(color)
.withContext(`In ${browserName}`)
.toEqual("rgb(255, 0, 0)");
const inputSelector = `${secondEditorSelector} .basicColorPicker`;
await page.waitForSelector(inputSelector, { visible: true });
const buttonColor = await page.evaluate(sel => {
const input = document.querySelector(sel);
return input.value;
}, inputSelector);
expect(buttonColor).withContext(`In ${browserName}`).toEqual("#ff0000");
}
});
it("must clear all", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {