Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Editor] Fix the focus outline for the comment dialog buttons

Browse Source 
And add an aria label to the dialog.
This commit is contained in:
Calixte Denizet 2025-09-18 14:01:04 +02:00
parent d85fd12437
commit a1906f02d9
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/comment_manager.css
View File

@ -38,11 +38,6 @@
align-items: flex-start; align-items: flex-start;
gap: 4px; gap: 4px;
*:focus-visible {
outline: 2px solid var(--comment-focus-outline-color);
outline-offset: 0;
}
#commentManagerToolbar { #commentManagerToolbar {
width: 100%; width: 100%;
height: 32px; height: 32px;

6
web/viewer.html
View File

@ -792,12 +792,12 @@ See https://github.com/adobe-type-tools/cmap-resources
</div> </div>
</dialog> </dialog>
<dialog class="dialog commentManager" id="commentManagerDialog"> <dialog class="dialog commentManager" id="commentManagerDialog" aria-labelledby="commentManagerTitle">
<div class="mainContainer"> <div class="mainContainer">
<div class="title" id="commentManagerToolbar"> <div class="title" id="commentManagerToolbar">
<span id="commentManagerTitle" role="sectionhead" data-l10n-id="pdfjs-editor-edit-comment-dialog-title-when-adding" tabindex="0"></span> <span id="commentManagerTitle" role="sectionhead" data-l10n-id="pdfjs-editor-edit-comment-dialog-title-when-adding"></span>
</div> </div>
<textarea id="commentManagerTextInput" data-l10n-id="pdfjs-editor-edit-comment-dialog-text-input"></textarea> <textarea id="commentManagerTextInput" data-l10n-id="pdfjs-editor-edit-comment-dialog-text-input" tabindex="0"></textarea>
<div class="dialogButtonsGroup"> <div class="dialogButtonsGroup">
<button id="commentManagerCancelButton" type="button" class="secondaryButton" tabindex="0"> <button id="commentManagerCancelButton" type="button" class="secondaryButton" tabindex="0">
<span data-l10n-id="pdfjs-editor-edit-comment-dialog-cancel-button"></span> <span data-l10n-id="pdfjs-editor-edit-comment-dialog-cancel-button"></span>