Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Add some telemetry in order to know what are the certificates used in pdfs (bug 1973573)"

Browse Source
This commit is contained in:
calixteman 2025-10-29 15:41:34 +01:00 committed by GitHub
parent 4a660967bd
commit aeceee1df3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
src/core/document.js
View File

@ -1167,49 +1167,6 @@ class PDFDocument {
});
}
#collectSignatureCertificates(
fields,
collectedSignatureCertificates,
visited = new RefSet()
) {
if (!Array.isArray(fields)) {
return;
}
for (let field of fields) {
if (field instanceof Ref) {
if (visited.has(field)) {
continue;
}
visited.put(field);
}
field = this.xref.fetchIfRef(field);
if (!(field instanceof Dict)) {
continue;
}
if (field.has("Kids")) {
this.#collectSignatureCertificates(
field.get("Kids"),
collectedSignatureCertificates,
visited
);
continue;
}
const isSignature = isName(field.get("FT"), "Sig");
if (!isSignature) {
continue;
}
const value = field.get("V");
if (!(value instanceof Dict)) {
continue;
}
const subFilter = value.get("SubFilter");
if (!(subFilter instanceof Name)) {
continue;
}
collectedSignatureCertificates.add(subFilter.name);
}
}
get _xfaStreams() {
const { acroForm } = this.catalog;
if (!acroForm) {
@ -1525,20 +1482,6 @@ class PDFDocument {
// specification).
const sigFlags = acroForm.get("SigFlags");
const hasSignatures = !!(sigFlags & 0x1);
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
if (hasSignatures) {
const collectedSignatureCertificates = new Set();
this.#collectSignatureCertificates(
fields,
collectedSignatureCertificates
);
if (collectedSignatureCertificates.size > 0) {
formInfo.collectedSignatureCertificates = Array.from(
collectedSignatureCertificates
);
}
}
}
const hasOnlyDocumentSignatures =
hasSignatures && this.#hasOnlyDocumentSignatures(fields);
formInfo.hasAcroForm = hasFields && !hasOnlyDocumentSignatures;
@ -1566,11 +1509,6 @@ class PDFDocument {
IsSignaturesPresent: formInfo.hasSignatures,
};
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
docInfo.collectedSignatureCertificates =
formInfo.collectedSignatureCertificates ?? null;
}
let infoDict;
try {
infoDict = xref.trailer.get("Info");

7
web/app.js
View File

@ -1718,13 +1718,6 @@ const PDFViewerApplication = {
if (pdfDocument !== this.pdfDocument) {
return; // The document was closed while the metadata resolved.
}
if (info.collectedSignatureCertificates) {
this.externalServices.reportTelemetry({
type: "signatureCertificates",
data: info.collectedSignatureCertificates,
});
}
this.documentInfo = info;
this.metadata = metadata;
this._contentDispositionFilename ??= contentDispositionFilename;