Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #18094 from Snuffleupagus/rm-unnecessary-signal

Browse Source 
Remove unnecessary `signal` parameter from `removeEventListener` calls
This commit is contained in:
Tim van der Meij 2024-05-15 13:34:41 +02:00 committed by GitHub
commit b800268fca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/app.js
View File

@ -2044,8 +2044,8 @@ const PDFViewerApplication = {
passive: true, passive: true,
signal, signal,
}); });
mainContainer.removeEventListener("scrollend", scrollend, { signal }); mainContainer.removeEventListener("scrollend", scrollend);
mainContainer.removeEventListener("blur", scrollend, { signal }); mainContainer.removeEventListener("blur", scrollend);
}; };
const scroll = () => { const scroll = () => {
if (this._isCtrlKeyDown) { if (this._isCtrlKeyDown) {
@ -2059,10 +2059,7 @@ const PDFViewerApplication = {
return; return;
} }
mainContainer.removeEventListener("scroll", scroll, { mainContainer.removeEventListener("scroll", scroll, { passive: true });
passive: true,
signal,
});
this._isScrolling = true; this._isScrolling = true;
mainContainer.addEventListener("scrollend", scrollend, { signal }); mainContainer.addEventListener("scrollend", scrollend, { signal });
mainContainer.addEventListener("blur", scrollend, { signal }); mainContainer.addEventListener("blur", scrollend, { signal });