Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix flakiness of CSS-only zoom test

Browse Source 
Update the test to wait for the `pagerendered`` event of a specific
page (1), so that the `pagerendered`` event of other pages from a
previously running render doesn't resolve the `waitForPageRendered`
promise.
This commit is contained in:
Nicolò Ribaudo 2025-02-28 15:21:52 +01:00
parent 50c573d16d
commit de9b041b5e
No known key found for this signature in database
GPG Key ID: AAFDA9101C58F338
2 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
test/integration/test_utils.mjs
View File

@ -568,16 +568,24 @@ function waitForAnnotationModeChanged(page) {
}); });
} }
function waitForPageRendered(page) { function waitForPageRendered(page, pageNumber) {
return createPromise(page, resolve => { return page.evaluateHandle(
const { eventBus } = window.PDFViewerApplication; number => [
eventBus.on("pagerendered", function handler(e) { new Promise(resolve => {
if (!e.isDetailView) { const { eventBus } = window.PDFViewerApplication;
resolve(); eventBus.on("pagerendered", function handler(e) {
eventBus.off("pagerendered", handler); if (
} !e.isDetailView &&
}); (number === undefined || e.pageNumber === number)
}); ) {
resolve();
eventBus.off("pagerendered", handler);
}
});
}),
],
pageNumber
);
} }
function waitForEditorMovedInDOM(page) { function waitForEditorMovedInDOM(page) {

4
test/integration/viewer_spec.mjs
View File

@ -328,7 +328,7 @@ describe("PDF viewer", () => {
const originalCanvasSize = await getCanvasSize(page); const originalCanvasSize = await getCanvasSize(page);
const factor = 2; const factor = 2;
const handle = await waitForPageRendered(page); const handle = await waitForPageRendered(page, 1);
await page.evaluate(scaleFactor => { await page.evaluate(scaleFactor => {
window.PDFViewerApplication.pdfViewer.increaseScale({ window.PDFViewerApplication.pdfViewer.increaseScale({
drawingDelay: 0, drawingDelay: 0,
@ -356,7 +356,7 @@ describe("PDF viewer", () => {
const originalCanvasSize = await getCanvasSize(page); const originalCanvasSize = await getCanvasSize(page);
const factor = 4; const factor = 4;
const handle = await waitForPageRendered(page); const handle = await waitForPageRendered(page, 1);
await page.evaluate(scaleFactor => { await page.evaluate(scaleFactor => {
window.PDFViewerApplication.pdfViewer.increaseScale({ window.PDFViewerApplication.pdfViewer.increaseScale({
drawingDelay: 0, drawingDelay: 0,