Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #19064 from timvandermeij/fix-intermittent

Browse Source 
Fix the "must check that an infinite loop is not triggered" integration test
This commit is contained in:
Tim van der Meij 2024-11-19 20:31:49 +01:00 committed by GitHub
commit e8fbb602c5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
test/integration/scripting_spec.mjs
View File

@ -1266,6 +1266,13 @@ describe("Interaction", () => {
await page.waitForFunction( await page.waitForFunction(
`${getQuerySelector("27R")}.value === "HEAO "` `${getQuerySelector("27R")}.value === "HEAO "`
); );
// The typing actions in the first textbox caused sandbox events to be
// queued. We don't close the document between tests, so we have to
// flush them here, by clicking the second textbox, so they don't leak
// through to the following test.
await page.click(getSelector("28R"));
await waitForSandboxTrip(page);
}) })
); );
}); });
@ -1276,30 +1283,19 @@ describe("Interaction", () => {
await waitForScripting(page); await waitForScripting(page);
await page.click(getSelector("28R")); await page.click(getSelector("28R"));
await page.$eval(getSelector("28R"), el => await page.keyboard.press("Home");
el.setSelectionRange(0, 0)
);
await page.type(getSelector("28R"), "Hello"); await page.type(getSelector("28R"), "Hello");
await page.waitForFunction( await page.waitForFunction(
`${getQuerySelector("28R")}.value !== "123"` `${getQuerySelector("28R")}.value === "Hello123"`
); );
let text = await page.$eval(getSelector("28R"), el => el.value); // The action triggers a `calculateNow` which in turn triggers a
expect(text).withContext(`In ${browserName}`).toEqual("Hello123"); // `resetForm (inducing a `calculateNow`) and a `calculateNow`.
// Without infinite loop prevention the field would be empty.
// The action will trigger a calculateNow which itself
// will trigger a resetForm (inducing a calculateNow) and a
// calculateNow.
await page.click("[data-annotation-id='31R']"); await page.click("[data-annotation-id='31R']");
await page.waitForFunction( await page.waitForFunction(
`${getQuerySelector("28R")}.value !== "Hello123"` `${getQuerySelector("28R")}.value === "123"`
); );
// Without preventing against infinite loop the field is empty.
text = await page.$eval(getSelector("28R"), el => el.value);
expect(text).withContext(`In ${browserName}`).toEqual("123");
}) })
); );
}); });