From a114d13308dea037045ac00a5491901c7c5ce0c7 Mon Sep 17 00:00:00 2001 From: gigaherz Date: Tue, 7 Aug 2012 17:00:42 +0200 Subject: [PATCH 1/3] Fix some minor issues/nits detected by JetBrains' WebStorm inspector. --- web/viewer.js | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/web/viewer.js b/web/viewer.js index 40102852b..237c082db 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -177,7 +177,7 @@ var Settings = (function SettingsClosure() { else if (isLocalStorageEnabled) database = localStorage.getItem('database') || '{}'; else - return false; + return; database = JSON.parse(database); if (!('files' in database)) @@ -351,8 +351,8 @@ var PDFView = { set page(val) { var pages = this.pages; var input = document.getElementById('pageNumber'); + var event = document.createEvent('UIEvents'); if (!(0 < val && val <= pages.length)) { - var event = document.createEvent('UIEvents'); event.initUIEvent('pagechange', false, false, window, 0); event.pageNumber = this.page; window.dispatchEvent(event); @@ -361,7 +361,6 @@ var PDFView = { pages[val - 1].updateStats(); currentPageNumber = val; - var event = document.createEvent('UIEvents'); event.initUIEvent('pagechange', false, false, window, 0); event.pageNumber = val; window.dispatchEvent(event); @@ -487,7 +486,7 @@ var PDFView = { noData // Error ocurred try downloading with just the url. ); } else { - url += '#pdfjs.action=download', '_parent'; + url += '#pdfjs.action=download'; window.open(url, '_parent'); } }, @@ -795,7 +794,7 @@ var PDFView = { // 2 if last scrolled up page before the visible pages var numVisible = visibleViews.length; if (numVisible === 0) { - info('No visible views.'); + //info('No visible views.'); return false; } for (var i = 0; i < numVisible; ++i) { @@ -944,7 +943,6 @@ var PDFView = { } else { this.page = pageNumber; // simple page } - return; } } else if (/^\d+$/.test(hash)) // page number this.page = hash; @@ -1015,7 +1013,7 @@ var PDFView = { extractPageText(pageIndex + 1); } ); - }; + } extractPageText(0); }, @@ -1701,13 +1699,13 @@ var CustomStyle = (function CustomStyleClosure() { //if all fails then set to undefined return (_cache[propName] = 'undefined'); - } + }; CustomStyle.setProp = function set(propName, element, str) { var prop = this.getProp(propName); if (prop != 'undefined') element.style[prop] = str; - } + }; return CustomStyle; })(); @@ -1776,7 +1774,7 @@ var TextLayerBuilder = function textLayerBuilder(textLayerDiv) { // Resume rendering renderTimer = setInterval(renderTextLayer, renderInterval); }, resumeInterval); - }; // textLayerOnScroll + } // textLayerOnScroll window.addEventListener('scroll', textLayerOnScroll, false); }; // endLayout From d01071f426c0d782f46531d7436323b29cb29882 Mon Sep 17 00:00:00 2001 From: gigaherz Date: Tue, 7 Aug 2012 17:54:05 +0200 Subject: [PATCH 2/3] Remove the commented out call to info() --- web/viewer.js | 1 - 1 file changed, 1 deletion(-) diff --git a/web/viewer.js b/web/viewer.js index 237c082db..eb3a1cfbb 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -794,7 +794,6 @@ var PDFView = { // 2 if last scrolled up page before the visible pages var numVisible = visibleViews.length; if (numVisible === 0) { - //info('No visible views.'); return false; } for (var i = 0; i < numVisible; ++i) { From eaffcfa9206645edfc8cce2e2382071d75cccdd7 Mon Sep 17 00:00:00 2001 From: gigaherz Date: Wed, 8 Aug 2012 20:26:24 +0200 Subject: [PATCH 3/3] Fix some typos in comments and variable names. Fix some nits in debugger.js. --- web/debugger.js | 14 +++++++------- web/viewer.js | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/web/debugger.js b/web/debugger.js index aeb3ab4ce..0cfe26355 100644 --- a/web/debugger.js +++ b/web/debugger.js @@ -44,7 +44,7 @@ var FontInspector = (function FontInspectorClosure() { } } return { - // Poperties/functions needed by PDFBug. + // Properties/functions needed by PDFBug. id: 'FontInspector', name: 'Font Inspector', panel: null, @@ -140,7 +140,7 @@ var StepperManager = (function StepperManagerClosure() { var stepperChooser = null; var breakPoints = {}; return { - // Poperties/functions needed by PDFBug. + // Properties/functions needed by PDFBug. id: 'Stepper', name: 'Stepper', panel: null, @@ -207,7 +207,7 @@ var StepperManager = (function StepperManagerClosure() { var Stepper = (function StepperClosure() { function Stepper(panel, pageIndex, initialBreakPoints) { this.panel = panel; - this.len; + this.len = 0; this.breakPoint = 0; this.nextBreakPoint = null; this.pageIndex = pageIndex; @@ -236,6 +236,7 @@ var Stepper = (function StepperClosure() { headerRow.appendChild(c('th', 'fn')); headerRow.appendChild(c('th', 'args')); + var self = this; for (var i = 0; i < IRQueue.fnArray.length; i++) { var line = c('tr'); line.className = 'line'; @@ -249,7 +250,6 @@ var Stepper = (function StepperClosure() { cbox.type = 'checkbox'; cbox.className = 'points'; cbox.checked = checked; - var self = this; cbox.onclick = (function(x) { return function() { if (this.checked) @@ -298,7 +298,7 @@ var Stepper = (function StepperClosure() { callback(); break; } - } + }; dom.addEventListener('keydown', listener, false); self.goTo(idx); }, @@ -331,7 +331,7 @@ var Stats = (function Stats() { return false; } return { - // Poperties/functions needed by PDFBug. + // Properties/functions needed by PDFBug. id: 'Stats', name: 'Stats', panel: null, @@ -429,12 +429,12 @@ var PDFBug = (function PDFBugClosure() { // Initialize all the debugging tools. var tools = this.tools; + var self = this; for (var i = 0; i < tools.length; ++i) { var tool = tools[i]; var panel = document.createElement('div'); var panelButton = document.createElement('button'); panelButton.textContent = tool.name; - var self = this; panelButton.addEventListener('click', (function(selected) { return function(event) { event.preventDefault(); diff --git a/web/viewer.js b/web/viewer.js index 9b810b76f..1e6bf8a12 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -431,7 +431,7 @@ var PDFView = { // } // ); // }, -// noData // Error ocurred try downloading with just the url. +// noData // Error occurred try downloading with just the url. // ); //#endif }, @@ -798,14 +798,14 @@ var PDFView = { search: function pdfViewStartSearch() { // Limit this function to run every ms. var SEARCH_TIMEOUT = 250; - var lastSeach = this.lastSearch; + var lastSearch = this.lastSearch; var now = Date.now(); - if (lastSeach && (now - lastSeach) < SEARCH_TIMEOUT) { + if (lastSearch && (now - lastSearch) < SEARCH_TIMEOUT) { if (!this.searchTimer) { this.searchTimer = setTimeout(function resumeSearch() { PDFView.search(); }, - SEARCH_TIMEOUT - (now - lastSeach) + SEARCH_TIMEOUT - (now - lastSearch) ); } return;