Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable the browser-tests in Google Chrome on the bots

Browse Source 
Given that `browsertest` repeatedly timeout in Google Chrome, and considering that Firefox is the primary development target, we stop running them on the bots to avoid having to repeatedly deal with this.

Note that we already disabled these tests *on Windows* almost three years ago, because of stability issues; see PR 14392.
This commit is contained in:
Jonas Jenwald 2024-11-27 17:51:32 +01:00
parent 052b001f0e
commit fd31e728f7
3 changed files with 8 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
gulpfile.mjs
View File

@ -686,12 +686,9 @@ function runTests(testsName, { bot = false, xfaOnly = false } = {}) {
if (!bot) { if (!bot) {
args.push("--reftest"); args.push("--reftest");
} else { } else {
const os = process.env.OS; // The browser-tests are too slow in Google Chrome on the bots,
if (/windows/i.test(os)) { // causing a timeout, hence disabling them for now.
// The browser-tests are too slow in Google Chrome on the Windows forceNoChrome = true;
// bot, causing a timeout, hence disabling them for now.
forceNoChrome = true;
}
} }
if (xfaOnly) { if (xfaOnly) {
args.push("--xfaOnly"); args.push("--xfaOnly");
@ -770,12 +767,10 @@ function makeRef(done, bot) {
let forceNoChrome = false; let forceNoChrome = false;
const args = ["test.mjs", "--masterMode"]; const args = ["test.mjs", "--masterMode"];
if (bot) { if (bot) {
const os = process.env.OS; // The browser-tests are too slow in Google Chrome on the bots,
if (/windows/i.test(os)) { // causing a timeout, hence disabling them for now.
// The browser-tests are too slow in Google Chrome on the Windows forceNoChrome = true;
// bot, causing a timeout, hence disabling them for now.
forceNoChrome = true;
}
args.push("--noPrompts", "--strictVerify"); args.push("--noPrompts", "--strictVerify");
} }
if (process.argv.includes("--noChrome") || forceNoChrome) { if (process.argv.includes("--noChrome") || forceNoChrome) {

7
test/driver.js
View File

@ -609,13 +609,6 @@ class Driver {
return; return;
} }
if (task.noChrome && window?.chrome) {
this._log(`Skipping file "${task.file}" (because on Chrome)\n`);
this.currentTask++;
this._nextTask();
return;
}
this._log('Loading file "' + task.file + '"\n'); this._log('Loading file "' + task.file + '"\n');
try { try {

3
test/test_manifest.json
View File

@ -10749,8 +10749,7 @@
"rounds": 1, "rounds": 1,
"type": "eq", "type": "eq",
"link": true, "link": true,
"talos": false, "talos": false
"noChrome": true
}, },
{ {
"id": "issue18956", "id": "issue18956",