Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #19005 from Snuffleupagus/core_utils-shorten

Browse Source 
Shorten a few helper functions in `src/core/core_utils.js`
This commit is contained in:
Jonas Jenwald 2024-11-05 21:46:44 +01:00 committed by GitHub
commit fdfcfbc351
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/core/core_utils.js
View File

@ -166,14 +166,13 @@ function toRomanNumerals(number, lowerCase = false) {
"The number should be a positive integer." "The number should be a positive integer."
); );
const romanBuf = []; const romanBuf = [];
let pos;
// Thousands // Thousands
while (number >= 1000) { while (number >= 1000) {
number -= 1000; number -= 1000;
romanBuf.push("M"); romanBuf.push("M");
} }
// Hundreds // Hundreds
pos = (number / 100) | 0; let pos = (number / 100) | 0;
number %= 100; number %= 100;
romanBuf.push(ROMAN_NUMBER_MAP[pos]); romanBuf.push(ROMAN_NUMBER_MAP[pos]);
// Tens // Tens
@ -191,10 +190,7 @@ function toRomanNumerals(number, lowerCase = false) {
// native function in the sense that it returns the ceiling value and that it // native function in the sense that it returns the ceiling value and that it
// returns 0 instead of `Infinity`/`NaN` for `x` values smaller than/equal to 0. // returns 0 instead of `Infinity`/`NaN` for `x` values smaller than/equal to 0.
function log2(x) { function log2(x) {
if (x <= 0) { return x > 0 ? Math.ceil(Math.log2(x)) : 0;
return 0;
}
return Math.ceil(Math.log2(x));
} }
function readInt8(data, offset) { function readInt8(data, offset) {
@ -573,13 +569,10 @@ function recoverJsURL(str) {
const jsUrl = regex.exec(str); const jsUrl = regex.exec(str);
if (jsUrl?.[2]) { if (jsUrl?.[2]) {
const url = jsUrl[2]; return {
let newWindow = false; url: jsUrl[2],
newWindow: jsUrl[1] === "app.launchURL" && jsUrl[3] === "true",
if (jsUrl[3] === "true" && jsUrl[1] === "app.launchURL") { };
newWindow = true;
}
return { url, newWindow };
} }
return null; return null;