Calixte Denizet
45578aa8f5
Create a sidebar object
...
For now its use is limited to the comment sidebar but it'll be used for the new one
containing the thumbnails.
And make the sidebar more accessible with the keyboard or a screen reader.
2025-11-28 16:22:26 +01:00
Calixte Denizet
cb36dc28a7
[Editor] Make sure the left (resp. right) corner of the popup is visible when in LTR (resp. RTL) (bug 1995579)
2025-10-22 22:47:20 +02:00
Calixte Denizet
76e0de6c08
[Editor] Make sure the editor is focused after the comment has been deleted (bug 1992832)
2025-10-07 21:31:09 +02:00
Calixte Denizet
2aef871d5d
[Editor] Make sure the comment dialog always have relative coordinates between 0% and 100%
...
This way, when the window is resized, the dialog stay visible.
2025-10-02 18:55:55 +02:00
Calixte Denizet
bb556dcb5c
[Editor] Add the possibility to unselect a comment from the sidebar
2025-10-01 14:36:12 +02:00
Calixte Denizet
02ddf277ab
[Editor] Add some telemetry for the commenting feature (bug 1991172)
2025-09-26 21:04:09 +02:00
Calixte Denizet
7fc7b79cd0
[Annotation] In reading mode with new commment stuff enabled, use the comment popup for annotations without a popup but with some contents (bug 1991029)
2025-09-26 18:24:55 +02:00
Calixte Denizet
f854770806
[Editor] Show the comments in the sidebar in the chronological order, newest to oldest (bug 1990762)
2025-09-26 10:10:43 +02:00
Calixte Denizet
442932f0b3
[Editor] Move the focus to the comment button once editing is done (bug 1990820)
2025-09-25 20:17:52 +02:00
Calixte Denizet
a372294ea3
[Editor] Make the comment sidebar resizable (bug 1990544)
2025-09-25 15:29:41 +02:00
calixteman
8448d08345
Merge pull request #20300 from calixteman/bug1990499
...
[Editor] Fix the button labels in the comment dialog (bug 1990499)
2025-09-25 15:29:20 +02:00
Calixte Denizet
7b67ed3454
[Editor] Fix the button labels in the comment dialog (bug 1990499)
2025-09-24 18:18:43 +02:00
Calixte Denizet
0427c1d93c
[Editor] Use some percent coordinates for the comment dialog (bug 1990104)
2025-09-24 17:59:30 +02:00
calixteman
ae3c23e28a
Merge pull request #20291 from calixteman/bug1977269
...
[Editor] When in HCM, don't apply light/dark color in the comment buttons (bug 1977269)
2025-09-23 20:27:01 +02:00
Calixte Denizet
5d079c10b6
[Editor] When in HCM, don't apply light/dark color in the comment buttons (bug 1977269)
...
Add fix the color name to use in HCM.
2025-09-22 17:31:11 +02:00
Calixte Denizet
623d422ddb
[Editor] Make sure the comment dialog is visible on the screen (bug 1989304)
2025-09-18 21:23:42 +02:00
Calixte Denizet
764c2e639c
[Editor] Fix the position of the comment popup and its dialog
...
Only fix the popup position if the user didn't change it.
And don't adjust the dialog position since it should have the same as the popup.
2025-09-15 21:26:36 +02:00
Calixte Denizet
b660b721f9
[Editor] Add a new popup for comments (bug 1987425)
...
And:
- improve the editing dialog in removing menu;
- position correctly the popup on the left/right depending on the direction value.
2025-09-15 08:24:26 +02:00
calixteman
d77f89026f
Merge pull request #20240 from calixteman/fix_contrast
...
Make sure that a good constrast ratio is respected when darkening/lightening a color
2025-09-12 09:24:40 +02:00
Calixte Denizet
7f85c00ee6
Make sure that a good constrast ratio is respected when darkening/lightening a color
2025-09-11 21:29:28 +02:00
Calixte Denizet
54351ee437
[Editor] When clicking on a comment in the sidebar, wait for the annotation editor layer to be rendered
...
and add a getter for the layer bounding rect.
2025-09-08 17:13:37 +02:00
Calixte Denizet
2a459857ce
[Editor] Add editors with a comment in the sidebar
...
and add a button close to the editor.
Clicking on the button will display a popup with the comment but it's for a next patch.
2025-08-31 19:59:16 +02:00
Tim van der Meij
5a7c872618
[Editor] Hide the comment sidebar on document change
...
If the document changes the comment state from the old document should
be replaced with that of the new document. To do this the comment
manager is destroyed, but the corresponding comment sidebar wasn't
destroyed yet, which resulted in the comment state from the old document
still being visible for the new document.
This commit fixes the issue by hiding the comment sidebar if the comment
manager is destroyed. Note that hiding the comment sidebar effectively
destroys all its state, and we already set the annotation mode to "none"
on document change so we don't want to keep showing the comment sidebar
anyway.
2025-08-31 16:26:03 +02:00
Calixte Denizet
0ec503e5ef
Add a function changeLightness in order to change the lightness of a RGB color
2025-08-30 21:18:12 +02:00
Calixte Denizet
25990e4287
[Editor] Add a sidebar allowing the user to navigate between the comments in a pdf (bug 1985567)
...
This implements what has been specified but it's still not done: we have to handle editing a comment
or an annotation containing one.
2025-08-29 16:00:06 +02:00
Calixte Denizet
efc1654326
[Editor] Don't show the actions button in the comment popup when it's useless
2025-07-25 19:47:58 +02:00
Calixte Denizet
636ff503ff
[Editor] Add the possibility to add Popup annotations (bug 1976724)
...
It's a first big step.
This patch contains a new modal dialog to let the user edit/update a Popup
2025-07-15 22:39:16 +02:00
