Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
21,178 Commits 1 Branch 101 Tags
Commit Graph

4159 Commits

Author SHA1 Message Date
Tim van der Meij
23bd705cea
Merge pull request #20080 from calixteman/add_comment_1 
[Editor] Add the possibility to add Popup annotations (bug 1976724)
 2025-07-17 21:07:06 +02:00
calixteman
d2f8e60794
Merge pull request #20098 from calixteman/update_highlight_color 
[Editor] Make possible to change the highlight color from the main panel
 2025-07-17 21:06:29 +02:00
Calixte Denizet
5162209b27 [Editor] Make possible to change the highlight color from the main panel 
It's consistent with the way to change colors for FreeText or Ink annotations.
 2025-07-17 20:57:51 +02:00
Calixte Denizet
86d58b637f Don't add an undefined id to the span for marked content 
It fixes #20102.
 2025-07-17 19:13:30 +02:00
Calixte Denizet
636ff503ff [Editor] Add the possibility to add Popup annotations (bug 1976724) 
It's a first big step.
This patch contains a new modal dialog to let the user edit/update a Popup
 2025-07-15 22:39:16 +02:00
calixteman
4f2390a607
Merge pull request #20070 from calixteman/editor_toolbar_color 
[Editor] Add a color picker in the toolbar of Ink and Freetext annotations
 2025-07-14 23:55:51 +02:00
Calixte Denizet
dbd6f8cdd4 [Editor] Add a color picker in the toolbar of Ink and Freetext annotations 2025-07-14 23:00:01 +02:00
calixteman
ac2a0c5080
Merge pull request #20085 from calixteman/bug1975719 
Handle the case where all the image data are in the alpha channel (bug 1975719)
 2025-07-14 22:44:19 +02:00
Tim van der Meij
a0f8cbafcf
Fix the "must check that canvas perfectly fits the page whatever the zoom level" viewer integration test 
In order to screenshot the page and assert that it's monochrome,
providing a regression test for #18694, the viewer background is
configured to match the page background because screenshotting the page
always captures a small part of the viewer background as well, and this
way we can easily go over all pixels and check that they are all equal.

However, in addition to configuring the viewer background the test also
hides the toolbar and removes the page border. Especially the latter
makes `scrollIntoView` fail in both Chrome and Firefox with recent
Puppeteer versions, for reasons which remain a bit unclear.

Fortunately both hiding the toolbar and removing the page border is not
actually necessary (anymore) for the test to work, so we can simply
remove those actions to fix the issue and reduce the amount of code. To
make sure that the test still covers the original issue correctly we've
reverted the changes from #18698 and then test still fails as expected.

Fixes #19811.
Fixes 68332ec2.
 2025-07-12 21:49:33 +02:00
Tim van der Meij
b7a0f01f40
Merge pull request #19976 from calixteman/write_popup 
[Editor] Add the possibility to add a popup to an annotation when saving
 2025-07-12 15:28:56 +02:00
Tim van der Meij
64b150f78f
Merge pull request #20077 from calixteman/remove_popup 
[Editor] Remove a popup from the DOM when it's deleted
 2025-07-12 15:25:49 +02:00
Calixte Denizet
6f8796d2c8 Handle the case where all the image data are in the alpha channel (bug 1975719) 
and add an error message in case where there is no data in the image.
 2025-07-11 22:34:37 +02:00
Calixte Denizet
b07914843b [Editor] Remove a popup from the DOM when it's deleted 2025-07-11 21:55:14 +02:00
Calixte Denizet
8fc51dc089 [Editor] Add the possibility to add a popup to an annotation when saving 
When saving/printing, only update the properties which are provided and set
a default value only when there is no pre-existing one.
 2025-07-11 21:42:21 +02:00
Calixte Denizet
0f504d9a1a Add the l10n parameter when pasting a Signature annotation 2025-07-10 21:01:24 +02:00
Calixte Denizet
e36f58ee4d Revert "Make horizontal padding relative to device width" 
This reverts commit c138887c1f7613bce44b99d22b63e2d744b0fb40.
 2025-07-09 17:38:49 +02:00
calixteman
1b427a3af5
Merge pull request #20016 from ryzokuken/move-getcontext 
[api-minor] Move getContext call to InternalRenderTask
 2025-07-08 22:20:19 +02:00
calixteman
0e2b59e3d5
Merge pull request #20064 from calixteman/dict_api 
Add few methods to the Dict class in order to simplify the code when writing an annotation
 2025-07-08 22:16:57 +02:00
calixteman
481b74a1c2
Merge pull request #20063 from calixteman/issue20062 
Fix the default appearance of a Polygon annotation when a fill color is provided
 2025-07-08 22:10:52 +02:00
Calixte Denizet
63b37b4371 Add few methods to the Dict class in order to simplify the code when writing an annotation 2025-07-08 21:23:29 +02:00
Calixte Denizet
ecc7096a80 Fix the default appearance of a Polygon annotation when a fill color is provided 
It fixes #20062.
 2025-07-08 20:51:58 +02:00
Tim van der Meij
b999d5ce58
Merge pull request #20060 from noritaka1166/fix-typos 
Fix typos across the codebase
 2025-07-08 18:28:52 +02:00
Calixte Denizet
bb52a440ce Use the creation date in the popup when there is no modification date 
Remove the h1 element in popup title because it caused a warning in Firefox and use a span instead.
 2025-07-07 10:51:35 +02:00
Noritaka Kobayashi
fa568e826d
Fix typos across the codebase 2025-07-07 09:59:36 +09:00
Tim van der Meij
cbeef3233f
Merge pull request #20056 from calixteman/one_click 
[Editor] Allow to change the editor mode when selecting the corresponding editor (bug 1975538)
 2025-07-06 19:35:31 +02:00
Ujjwal Sharma
b1b728d47f [api-minor] Move getContext call to InternalRenderTask 
This is a precursor to moving the call into a
worker thread to let us use `OffscreenCanvas`. The
current position wouldn't work since we make
transformations to the canvas object after the
getContext call, which isn't allowed for
OffscreenCanvas. Also it isn't allowed to clone or
`transferControlToOffscreen` the canvas after the
`getContext` call.
 2025-07-04 00:53:51 +02:00
Calixte Denizet
6d2c6cfc9f [Editor] Allow to change the editor mode when selecting the corresponding editor (bug 1975538) 
For example, selecting an ink editor just after having created a freetext will switch to ink mode.
 2025-07-03 23:27:34 +02:00
calixteman
2d0ba7db08
Merge pull request #20043 from yyliu12/popup-rotation-fix 
Make Popup annotations always have noRotate flag set as true
 2025-07-03 17:27:40 +02:00
calixteman
ad31385792
Merge pull request #20055 from calixteman/bug1975264 
[Editor] When an annotation is added, announce it if the user is using a screen reader (bug 1975264)
 2025-07-03 17:23:56 +02:00
calixteman
54c0d56ccf
Merge pull request #20054 from calixteman/bug1974863 
Don't focus the viewer at startup (bug 1974863)
 2025-07-03 17:01:19 +02:00
Calixte Denizet
c22a425b04 [Editor] When an annotation is added, announce it if the user is using a screen reader (bug 1975264) 2025-07-03 16:53:01 +02:00
calixteman
fd87e668e0
Merge pull request #20047 from Aditi-1400/fix-horizontal-scroll 
Make horizontal padding relative to device width
 2025-07-03 16:52:15 +02:00
Yuyang Liu
d8ecfad8bd Make Popup annotations always have noRotate flag set as true 
Necessary because when there is no Popup annotation created along
with a Text annotation, the Popup annotation created by pdf.js
does not receive the noRotate flag
 2025-07-03 05:52:31 +09:00
Calixte Denizet
aaae516894 Don't focus the viewer at startup (bug 1974863) 
It's useless and it causes screen readers to not always read the document title.
 2025-07-02 17:34:23 +02:00
calixteman
426ee03488
Merge pull request #20041 from calixteman/bug1974436 
Remove the shadow from the links (bug 1974436)
 2025-07-01 12:59:17 +02:00
Tim van der Meij
8f2a4561b2
Merge pull request #20039 from calixteman/bug1974257 
[Editor] In the signature modal, disable the save checkbox when the storage is full (bug 1974257)
 2025-06-30 21:46:38 +02:00
Calixte Denizet
9acd16a0c7 [Editor] In the signature modal, disable the save checkbox when the storage is full (bug 1974257) 2025-06-30 21:42:28 +02:00
Calixte Denizet
fc9ba0cda3 Remove the shadow from the links (bug 1974436) 
The shadow was taken into account when computing the bounding box of the section
containing the link and it was making the clip path wrong.
Since the shadow is almost invisible because of the opacity, the yellow color and the clip
we can remove it without causing any visual regressions (and as a side effect it'll avoid
to use resources to compute it when displayed).
 2025-06-30 21:39:22 +02:00
Aditi
c138887c1f Make horizontal padding relative to device width 
The fixed -400px horizontal offset used by
scrollIntoView led to horizontal scroll only moving
part-way right on narrow screens. The highlights near
the right-edge remained party or completely off
screen.

This centres the highlighted match on any viewport width while
clamping the left margin to 20-400px. On very narrow screens
the scrollbar now moves all the way to the right instead of
stopping midway.
 2025-06-30 19:08:02 +05:30
Calixte Denizet
bb6b42177c Don't remove a dash at the end of a line when guessing urls (bug 1974112) 2025-06-26 18:55:59 +02:00
Calixte Denizet
3bdc5d54fe Get the text under highlight/squiggly/underline/strikethrough annotations (bug 1885505) 
and add an invisible element containing the text in the annotation layer to make
it readable by a screen reader.
 2025-06-22 21:47:29 +02:00
Tim van der Meij
ac399e77e8
Merge pull request #20023 from calixteman/edit_added_annotation 
[Editor] When editing mode is disabled, allow to double click on a added annotation to edit it
 2025-06-21 16:23:56 +02:00
Calixte Denizet
eafc040734 Allow to have an URL as file parameter when loading the viewer 2025-06-21 14:57:24 +02:00
calixteman
e78575e593
Merge pull request #19986 from calixteman/dont_show_empty_popup 
Only show popups when they've some contents to display
 2025-06-20 13:48:30 +02:00
Calixte Denizet
b97cee2ab5 Correctly handle files with a hash sign in their names (bug 1894166) 
It fixes #19990.
 2025-06-20 09:21:41 +02:00
Calixte Denizet
2541d96bf5 [JS] Make the date parser less strict 
and display the expected date formt as a tooltip.
 2025-06-20 08:57:07 +02:00
Calixte Denizet
d0b0064643 [Editor] When editing mode is disabled, allow to double click on a added annotation to edit it 
It's already possible but only when double clicking outside the the text layer.
This patach adds the possibility to click on the text layer.
 2025-06-19 21:15:08 +02:00
Calixte Denizet
96216de410 Only show popups when they've some contents to display 
Chrome, Edge and Acrobat do that.
 2025-06-19 16:33:52 +02:00
calixteman
412500c9b9
Merge pull request #19996 from calixteman/bug1961423_bis 
Fix a printing issue on Mac (bug 1961423)
 2025-06-17 21:23:49 +02:00
calixteman
35b604b9f8
Merge pull request #20011 from calixteman/bug1971134 
[Editor] Fix the text alignment in freetext annotations (bug 1971134)
 2025-06-17 21:18:50 +02:00