Tim van der Meij
ed141970e6
Merge pull request #20099 from calixteman/bug1977259
...
[Editor] Fix the highlighting colors in HCM (bug 1977259)
2025-07-18 22:25:43 +02:00
Tim van der Meij
f3080a185b
Merge pull request #20106 from timvandermeij/fix-viewer-alert-intermittent
...
Fix intermittent failure in the viewer alert tests
2025-07-18 21:32:26 +02:00
Tim van der Meij
603fd2524a
Fix intermittent failure in the viewer alert tests
...
It takes some time for the viewer alert to be updated after the editor
is committed, but the current tests don't await that and proceed too
fast to the viewer alert string assertion. This commit fixes the issue
by waiting for the expected viewer alert string to appear instead.
2025-07-18 20:56:02 +02:00
Tim van der Meij
daf2cbbfe9
Merge pull request #20096 from calixteman/bug1708041
...
Make the link annotations correctly announced by screen readers (bug 1708041)
2025-07-18 20:33:30 +02:00
Calixte Denizet
f695e0ca62
Make the link annotations correctly announced by screen readers (bug 1708041)
...
And focus the targeted page when the user clicks on a link.
2025-07-18 20:15:31 +02:00
Calixte Denizet
c022a3294a
[Editor] Fix the highlighting colors in HCM (bug 1977259)
...
Using the same color in HCM or non-HCM was inducing a too small contrast between
some bg/fg colors making the text a bit hard to read.
2025-07-18 20:11:28 +02:00
calixteman
bfc7fc4da9
Merge pull request #20101 from calixteman/issue20065
...
Use canvas context text primitives when the font file is missing
2025-07-18 20:03:22 +02:00
Calixte Denizet
8b17e5ecd8
Use canvas context text primitives when the font file is missing
...
It fixes #20065 .
The only to get a path (from the path generator) is when the font is embedded.
So when we need a path (disableFontFace: true or when we want to use a pattern for stroking/filling), it's impossible
to fulfil.
2025-07-18 19:57:30 +02:00
Tim van der Meij
e4585c2452
Merge pull request #20104 from calixteman/fix_newpopup
...
[Editor] Only add a popup to an existing annotation if it exits
2025-07-18 19:34:03 +02:00
Calixte Denizet
6d7e0e7025
[Editor] Only add a popup to an existing annotation if it exits
...
It fixes the ink integration test "must update an existing annotation".
2025-07-18 17:31:53 +02:00
Tim van der Meij
23bd705cea
Merge pull request #20080 from calixteman/add_comment_1
...
[Editor] Add the possibility to add Popup annotations (bug 1976724)
2025-07-17 21:07:06 +02:00
calixteman
d2f8e60794
Merge pull request #20098 from calixteman/update_highlight_color
...
[Editor] Make possible to change the highlight color from the main panel
2025-07-17 21:06:29 +02:00
Calixte Denizet
5162209b27
[Editor] Make possible to change the highlight color from the main panel
...
It's consistent with the way to change colors for FreeText or Ink annotations.
2025-07-17 20:57:51 +02:00
Tim van der Meij
ef9292094c
Merge pull request #20103 from calixteman/avoid_undefined_id
...
Don't add an undefined id to the span for marked content
2025-07-17 20:36:16 +02:00
Calixte Denizet
86d58b637f
Don't add an undefined id to the span for marked content
...
It fixes #20102 .
2025-07-17 19:13:30 +02:00
Calixte Denizet
636ff503ff
[Editor] Add the possibility to add Popup annotations (bug 1976724)
...
It's a first big step.
This patch contains a new modal dialog to let the user edit/update a Popup
2025-07-15 22:39:16 +02:00
Tim van der Meij
9f645fb9a6
Merge pull request #20095 from calixteman/issue20091
...
[Editor] Make sure that doorhangers are large enough to fit localized strings
2025-07-15 19:50:48 +02:00
Tim van der Meij
be10bb8c7b
Merge pull request #20094 from calixteman/use_rounded_color_swatch
...
[Editor] Use a round color swatch for the basic color picker
2025-07-15 19:48:07 +02:00
Calixte Denizet
ca4e219b7b
[Editor] Make sure that doorhangers are large enough to fit localized strings
...
It fixes #20091 .
2025-07-15 17:14:44 +02:00
Calixte Denizet
b2aba463a5
[Editor] Use a round color swatch for the basic color picker
2025-07-15 15:06:07 +02:00
calixteman
5600c0ac02
Merge pull request #20092 from calixteman/mv_a11y_alert
...
Avoid Firefox test failure
2025-07-15 10:53:32 +02:00
Calixte Denizet
6b5aee2923
Avoid Firefox test failure
...
It fixes test: accessible/tests/mochitest/elm/test_HTMLSpec.html
2025-07-15 10:50:38 +02:00
calixteman
4f2390a607
Merge pull request #20070 from calixteman/editor_toolbar_color
...
[Editor] Add a color picker in the toolbar of Ink and Freetext annotations
2025-07-14 23:55:51 +02:00
Calixte Denizet
dbd6f8cdd4
[Editor] Add a color picker in the toolbar of Ink and Freetext annotations
2025-07-14 23:00:01 +02:00
calixteman
ac2a0c5080
Merge pull request #20085 from calixteman/bug1975719
...
Handle the case where all the image data are in the alpha channel (bug 1975719)
2025-07-14 22:44:19 +02:00
calixteman
e0783cd075
Merge pull request #20086 from timvandermeij/updates
...
Update dependencies and translations to the most recent versions
2025-07-13 19:47:11 +02:00
calixteman
9070a2786a
Merge pull request #20087 from timvandermeij/fix-intermittent-viewer
...
Fix the "must check that canvas perfectly fits the page whatever the zoom level" viewer integration test
2025-07-13 13:54:24 +02:00
Tim van der Meij
a0f8cbafcf
Fix the "must check that canvas perfectly fits the page whatever the zoom level" viewer integration test
...
In order to screenshot the page and assert that it's monochrome,
providing a regression test for #18694 , the viewer background is
configured to match the page background because screenshotting the page
always captures a small part of the viewer background as well, and this
way we can easily go over all pixels and check that they are all equal.
However, in addition to configuring the viewer background the test also
hides the toolbar and removes the page border. Especially the latter
makes `scrollIntoView` fail in both Chrome and Firefox with recent
Puppeteer versions, for reasons which remain a bit unclear.
Fortunately both hiding the toolbar and removing the page border is not
actually necessary (anymore) for the test to work, so we can simply
remove those actions to fix the issue and reduce the amount of code. To
make sure that the test still covers the original issue correctly we've
reverted the changes from #18698 and then test still fails as expected.
Fixes #19811 .
Fixes 68332ec2.
2025-07-12 21:49:33 +02:00
Tim van der Meij
3054942101
Update translations to the most recent versions
2025-07-12 20:21:07 +02:00
Tim van der Meij
7a129f8eae
Update dependencies to the most recent versions
2025-07-12 20:20:05 +02:00
Tim van der Meij
b7a0f01f40
Merge pull request #19976 from calixteman/write_popup
...
[Editor] Add the possibility to add a popup to an annotation when saving
2025-07-12 15:28:56 +02:00
Tim van der Meij
64b150f78f
Merge pull request #20077 from calixteman/remove_popup
...
[Editor] Remove a popup from the DOM when it's deleted
2025-07-12 15:25:49 +02:00
Calixte Denizet
6f8796d2c8
Handle the case where all the image data are in the alpha channel (bug 1975719)
...
and add an error message in case where there is no data in the image.
2025-07-11 22:34:37 +02:00
Calixte Denizet
b07914843b
[Editor] Remove a popup from the DOM when it's deleted
2025-07-11 21:55:14 +02:00
Calixte Denizet
8fc51dc089
[Editor] Add the possibility to add a popup to an annotation when saving
...
When saving/printing, only update the properties which are provided and set
a default value only when there is no pre-existing one.
2025-07-11 21:42:21 +02:00
Tim van der Meij
e853a8f41a
Merge pull request #20081 from calixteman/signature_description
...
Add the l10n parameter when pasting a Signature annotation
2025-07-11 20:27:06 +02:00
Tim van der Meij
c296fb8f95
Merge pull request #20084 from calixteman/hcm_popup_trigger_area
...
In HCM, invert colors when hovering an annotation with a popup
2025-07-11 20:22:31 +02:00
Tim van der Meij
094253f2de
Merge pull request #20082 from calixteman/fix_firefox_printing
...
Use the canvas context from mozPrintCallback when printing a pdf from the Firefox viewer
2025-07-11 20:21:03 +02:00
Calixte Denizet
7091647039
In HCM, invert colors when hovering an annotation with a popup
2025-07-11 15:35:35 +02:00
Calixte Denizet
1c15ba7789
Use the canvas context from mozPrintCallback when printing a pdf from the Firefox viewer
...
The context is specific to the callback and cannot be created from the canvas itself.
2025-07-11 12:55:39 +02:00
Calixte Denizet
0f504d9a1a
Add the l10n parameter when pasting a Signature annotation
2025-07-10 21:01:24 +02:00
calixteman
2e0f1ec515
Merge pull request #20076 from calixteman/revert_20047
...
Revert "Make horizontal padding relative to device width"
2025-07-09 18:09:26 +02:00
Calixte Denizet
e36f58ee4d
Revert "Make horizontal padding relative to device width"
...
This reverts commit c138887c1f7613bce44b99d22b63e2d744b0fb40.
2025-07-09 17:38:49 +02:00
calixteman
2dadac8877
Merge pull request #20071 from ryzokuken/bump-version-5.4
...
Bump library version to `5.4`
2025-07-09 14:57:13 +02:00
Ujjwal Sharma
1d702d4d6d
Bump library version to 5.4
2025-07-08 23:27:41 +02:00
calixteman
1b427a3af5
Merge pull request #20016 from ryzokuken/move-getcontext
...
[api-minor] Move getContext call to InternalRenderTask
2025-07-08 22:20:19 +02:00
calixteman
0e2b59e3d5
Merge pull request #20064 from calixteman/dict_api
...
Add few methods to the Dict class in order to simplify the code when writing an annotation
2025-07-08 22:16:57 +02:00
calixteman
481b74a1c2
Merge pull request #20063 from calixteman/issue20062
...
Fix the default appearance of a Polygon annotation when a fill color is provided
2025-07-08 22:10:52 +02:00
Calixte Denizet
63b37b4371
Add few methods to the Dict class in order to simplify the code when writing an annotation
2025-07-08 21:23:29 +02:00
Calixte Denizet
ecc7096a80
Fix the default appearance of a Polygon annotation when a fill color is provided
...
It fixes #20062 .
2025-07-08 20:51:58 +02:00