Beanz/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
21,294 Commits 1 Branch 101 Tags
Commit Graph

4780 Commits

Author SHA1 Message Date
calixteman
8ba18075f2
Merge pull request #20344 from calixteman/bug1992770 
[Editor] Make sure that annotation positions in the DOM respect the visual order (bug 1992770)
 2025-10-08 16:55:01 +02:00
Calixte Denizet
41dea1e38b [Editor] Make sure that annotation positions in the DOM respect the visual order (bug 1992770) 2025-10-08 15:11:09 +02:00
Calixte Denizet
2d759a5f4b [Editor] Remove the role radio for the editing buttons (bug 1990826) 2025-10-08 14:45:28 +02:00
Calixte Denizet
76e0de6c08 [Editor] Make sure the editor is focused after the comment has been deleted (bug 1992832) 2025-10-07 21:31:09 +02:00
Calixte Denizet
3ecefa5e0c [Editor] Slightly move the resizer in the sidebar comment in order to make it easier to use (bug 1992385) 
And highlight the resizer when hovering it.
 2025-10-03 17:07:42 +02:00
calixteman
e1de28c866
Merge pull request #20328 from calixteman/fix_dialog_position 
[Editor] Make sure the comment dialog always have relative coordinates between 0% and 100%
 2025-10-03 09:17:09 +02:00
Calixte Denizet
2aef871d5d [Editor] Make sure the comment dialog always have relative coordinates between 0% and 100% 
This way, when the window is resized, the dialog stay visible.
 2025-10-02 18:55:55 +02:00
calixteman
9d917b2896
Merge pull request #20323 from calixteman/bug1991482 
Increase the rendering quality of the detail view (bug 1991482)
 2025-10-01 19:29:17 +02:00
Calixte Denizet
91e2f6c400 Increase the rendering quality of the detail view (bug 1991482) 
But keep a lower quality when enableOptimizedPartialRendering is true because we need to compensate the time
used to compute the bboxes and since subsequent rendering are faster it's more acceptable to see
a lower quality image for few tenths of seconds.
 2025-10-01 16:40:41 +02:00
Calixte Denizet
bb556dcb5c [Editor] Add the possibility to unselect a comment from the sidebar 2025-10-01 14:36:12 +02:00
calixteman
d18289bccb
Merge pull request #20321 from calixteman/bug1989420 
[Editor] Add a fake annotation (in the annotation layer) associated with an editor in order to be able to show the comment button (bug 1989420)
 2025-10-01 00:40:13 -11:00
Calixte Denizet
12066af578 [Editor] Add a fake annotation (in the annotation layer) associated with an editor in order to be able to show the comment button (bug 1989420) 2025-10-01 09:08:57 +02:00
Calixte Denizet
7041459fc0 [Editor] Remove useless sidebar css 2025-09-26 22:32:54 +02:00
Calixte Denizet
02ddf277ab [Editor] Add some telemetry for the commenting feature (bug 1991172) 2025-09-26 21:04:09 +02:00
Calixte Denizet
7fc7b79cd0 [Annotation] In reading mode with new commment stuff enabled, use the comment popup for annotations without a popup but with some contents (bug 1991029) 2025-09-26 18:24:55 +02:00
calixteman
28fb4f0f47
Merge pull request #20310 from calixteman/bug1990762 
[Editor] Show the comments in the sidebar in the chronological order,newest to oldest (bug 1990762)
 2025-09-26 11:09:27 +02:00
Calixte Denizet
f854770806 [Editor] Show the comments in the sidebar in the chronological order, newest to oldest (bug 1990762) 2025-09-26 10:10:43 +02:00
Calixte Denizet
5f832757bd [Editor] Fix the URL for the 'Learn more' link in the comment sidebar (bug 1990454) 2025-09-26 09:16:36 +02:00
Calixte Denizet
442932f0b3 [Editor] Move the focus to the comment button once editing is done (bug 1990820) 2025-09-25 20:17:52 +02:00
Calixte Denizet
a372294ea3 [Editor] Make the comment sidebar resizable (bug 1990544) 2025-09-25 15:29:41 +02:00
calixteman
8448d08345
Merge pull request #20300 from calixteman/bug1990499 
[Editor] Fix the button labels in the comment dialog (bug 1990499)
 2025-09-25 15:29:20 +02:00
Calixte Denizet
7b67ed3454 [Editor] Fix the button labels in the comment dialog (bug 1990499) 2025-09-24 18:18:43 +02:00
Calixte Denizet
0427c1d93c [Editor] Use some percent coordinates for the comment dialog (bug 1990104) 2025-09-24 17:59:30 +02:00
Calixte Denizet
80c7aee347 [Editor] Avoid to use similar colors for background and foreground colors in HCM (bug 1990082) 2025-09-24 17:04:27 +02:00
Calixte Denizet
3f1dbbcb77 [Editor] Don't add scrollbars when it's useless in the comment sidebar (bug 1990099) 2025-09-24 15:38:13 +02:00
calixteman
ae3c23e28a
Merge pull request #20291 from calixteman/bug1977269 
[Editor] When in HCM, don't apply light/dark color in the comment buttons (bug 1977269)
 2025-09-23 20:27:01 +02:00
calixteman
225b07aa29
Merge pull request #20283 from calixteman/bug1989304 
[Editor] Make sure the comment dialog is visible on the screen (bug 1989304)
 2025-09-23 19:30:28 +02:00
Calixte Denizet
5d079c10b6 [Editor] When in HCM, don't apply light/dark color in the comment buttons (bug 1977269) 
Add fix the color name to use in HCM.
 2025-09-22 17:31:11 +02:00
Calixte Denizet
623d422ddb [Editor] Make sure the comment dialog is visible on the screen (bug 1989304) 2025-09-18 21:23:42 +02:00
Tim van der Meij
20f31d782b
Merge pull request #20281 from calixteman/comment_dialog_focus 
[Editor] Fix the focus outline for the comment dialog buttons
 2025-09-18 20:50:50 +02:00
Calixte Denizet
a1906f02d9 [Editor] Fix the focus outline for the comment dialog buttons 
And add an aria label to the dialog.
 2025-09-18 14:01:07 +02:00
Calixte Denizet
d1f06fe70e Avoid unused css variables 2025-09-16 13:40:09 +02:00
Calixte Denizet
764c2e639c [Editor] Fix the position of the comment popup and its dialog 
Only fix the popup position if the user didn't change it.
And don't adjust the dialog position since it should have the same as the popup.
 2025-09-15 21:26:36 +02:00
Calixte Denizet
38b86cb97a [Annotation] Use the new popup in reading mode (bug 1987426) 2025-09-15 16:58:22 +02:00
calixteman
3432c1933e
Merge pull request #20249 from calixteman/new_comment_popup_2 
[Editor] Add a new popup for comments (bug 1987425)
 2025-09-15 08:27:17 +02:00
Calixte Denizet
b660b721f9 [Editor] Add a new popup for comments (bug 1987425) 
And:
 - improve the editing dialog in removing menu;
 - position correctly the popup on the left/right depending on the direction value.
 2025-09-15 08:24:26 +02:00
Nicolò Ribaudo
5de14aa429
Only record bboxes when needed 
Before this patch, when `enableOptimizedPartialRendering`
is enabled we would record the bounding boxes of the
various operations on the first render.

This patches change it to happen on the first render that we
know will also need a detail view, so that the performance
cost is not paid for the case when the detail view is not used.
 2025-09-12 15:02:24 +02:00
calixteman
beb5f5ca85
Merge pull request #20208 from nicolo-ribaudo/bboxes-typedarray 
Store ops bboxes in a linear Uint8Array
 2025-09-12 14:52:42 +02:00
calixteman
d77f89026f
Merge pull request #20240 from calixteman/fix_contrast 
Make sure that a good constrast ratio is respected when darkening/lightening a color
 2025-09-12 09:24:40 +02:00
calixteman
0e28b5c3c4
Merge pull request #20258 from calixteman/cleanup_before_editing_mode 
[Editor] Cleanup the pages not being fully rendered before switching to editing mode
 2025-09-11 23:03:08 +02:00
Tim van der Meij
e8cc25c0ae
Merge pull request #20259 from calixteman/no_throw_when_switching_editing_mode 
[Editor] Don't throw when switching to editing mode before an annotation editor layer is rendered
 2025-09-11 22:04:47 +02:00
Calixte Denizet
7f85c00ee6 Make sure that a good constrast ratio is respected when darkening/lightening a color 2025-09-11 21:29:28 +02:00
Tim van der Meij
557eb2c7e1
Merge pull request #20253 from calixteman/scroll_and_center 
Add an option in scrollIntoView and goToXY in order to be able to center vertically or horizontally the point XY in the viewer container
 2025-09-11 21:20:55 +02:00
Nicolò Ribaudo
4c7bbd0fef
Reduce background canvas resolution 
The size of the canvas has significant impact on the rendering
performance. If we are going to render a high-res detail
view on top of the full-page canvas, we can further
reduce the full-page canvas resolution to improve
rendering time without affecting the resolution seen by
the user.

Users will se the lower resolution when quickly scrolling around the
page, but it will then be replaced with the high-res
detail view.
 2025-09-10 16:52:57 +02:00
Calixte Denizet
593ceadc93 [Editor] Don't throw when switching to editing mode before an annotation editor layer is rendered 
It can happen with a pdf having a large text layer.
Instead of waiting for the first rendered page to enable the buttons we wait for
a rendered annotation editor layer.
 2025-09-10 11:04:47 +02:00
Calixte Denizet
0fc8986dc6 [Editor] Cleanup the pages not being fully rendered before switching to editing mode 
In order to see the issue this patch is fixing:
 - open a pdf with some highlights and a comment on page 1, at page 7
 - open the comment sidebar
 - click on the comment on page 1

Opening at page 7 lets a not fully rendered page which means that when jumping to it
with the sidebar, we re-use what we've instead of redrawing it.
 2025-09-10 10:23:29 +02:00
Calixte Denizet
e1bdc34b4a Add an option in scrollIntoView and goToXY in order to be able to center vertically or horizontally the point XY in the viewer container 2025-09-09 13:10:49 +02:00
Nicolò Ribaudo
e4ea2e0c79
Store ops bboxes in a linear Uint8Array 
This PR changes the way we store bounding boxes so that they use less
memory and can be more easily shared across threads in the future.

Instead of storing the bounding box and list of dependencies for each
operation that renders _something_, we now only store the bounding box
of _every_ operation and no dependencies list. The bounding box of
each operation covers the bounding box of all the operations affected
by it that render something. For example, the bounding box of a
`setFont` operation will be the bounding box of all the `showText`
operations that use that font.

This affects the debugging experience in pdfBug, since now the bounding
box of an operation may be larger than what it renders itself. To help
with this, now when hovering on an operation we also highlight (in red)
all its dependents. We highlight with white stripes operations that do
not affect any part of the page (i.e. with an empty bbox).

To save memory, we now save bounding box x/y coordinates as uint8
rather than float64. This effectively gives us a 256x256 uniform grid
that covers the page, which is high enough resolution for the usecase.
 2025-09-09 10:24:48 +02:00
Calixte Denizet
54351ee437 [Editor] When clicking on a comment in the sidebar, wait for the annotation editor layer to be rendered 
and add a getter for the layer bounding rect.
 2025-09-08 17:13:37 +02:00
Calixte Denizet
35c909843b Add a new function renderRichText to be used in the annotation layer 
and which will be used in order to make the contents of the new popup used for comments.
 2025-09-04 22:27:31 +02:00