The first goal of this patch was to remove the tabindex because it helps to improve overall a11y. That led to move some html elements associated with the buttons which helped to position these elements relatively to their buttons. Consequently it was easy to change the toolbar height (configurable in Firefox with the pref browser.uidensity): it's the second goal of this patch. For a11y reasons we want to be able to change the height of the toolbar to make the buttons larger.
130 lines
5.1 KiB
JavaScript
130 lines
5.1 KiB
JavaScript
/* Copyright 2021 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { closePages, loadAndWait } from "./test_utils.mjs";
|
|
|
|
function fuzzyMatch(a, b, browserName, pixelFuzz = 3) {
|
|
expect(a)
|
|
.withContext(`In ${browserName}`)
|
|
.toBeLessThan(b + pixelFuzz);
|
|
expect(a)
|
|
.withContext(`In ${browserName}`)
|
|
.toBeGreaterThan(b - pixelFuzz);
|
|
}
|
|
|
|
describe("find bar", () => {
|
|
describe("highlight all", () => {
|
|
let pages;
|
|
|
|
beforeAll(async () => {
|
|
pages = await loadAndWait("find_all.pdf", ".textLayer", 100);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must highlight text in the right position", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
// Highlight all occurrences of the letter A (case insensitive).
|
|
await page.click("#viewFindButton");
|
|
await page.waitForSelector("#viewFindButton", { hidden: false });
|
|
await page.type("#findInput", "a");
|
|
await page.click("#findHighlightAll + label");
|
|
await page.waitForSelector(".textLayer .highlight");
|
|
|
|
// The PDF file contains the text 'AB BA' in a monospace font on a
|
|
// single line. Check if the two occurrences of A are highlighted.
|
|
const highlights = await page.$$(".textLayer .highlight");
|
|
expect(highlights.length).withContext(`In ${browserName}`).toEqual(2);
|
|
|
|
// Normalize the highlight's height. The font data in the PDF sets the
|
|
// size of the glyphs (and therefore the size of the highlights), but
|
|
// the viewer applies extra padding to them. For the comparison we
|
|
// therefore use the unpadded, glyph-sized parent element's height.
|
|
const parentSpan = (await highlights[0].$$("xpath/.."))[0];
|
|
const parentBox = await parentSpan.boundingBox();
|
|
const firstA = await highlights[0].boundingBox();
|
|
const secondA = await highlights[1].boundingBox();
|
|
firstA.height = parentBox.height;
|
|
secondA.height = parentBox.height;
|
|
|
|
// Check if the vertical position of the highlights is correct. Both
|
|
// should be on a single line.
|
|
expect(firstA.y).withContext(`In ${browserName}`).toEqual(secondA.y);
|
|
|
|
// Check if the height of the two highlights is correct. Both should
|
|
// match the font size.
|
|
const fontSize = 26.66; // From the PDF.
|
|
fuzzyMatch(firstA.height, fontSize, browserName);
|
|
fuzzyMatch(secondA.height, fontSize, browserName);
|
|
|
|
// Check if the horizontal position of the highlights is correct. The
|
|
// second occurrence should be four glyph widths (three letters and
|
|
// one space) away from the first occurrence.
|
|
const pageDiv = await page.$(".page canvas");
|
|
const pageBox = await pageDiv.boundingBox();
|
|
const expectedFirstAX = 30; // From the PDF.
|
|
const glyphWidth = 15.98; // From the PDF.
|
|
fuzzyMatch(firstA.x, pageBox.x + expectedFirstAX, browserName);
|
|
fuzzyMatch(secondA.x, firstA.x + glyphWidth * 4, browserName);
|
|
})
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("highlight all (XFA)", () => {
|
|
let pages;
|
|
|
|
beforeAll(async () => {
|
|
pages = await loadAndWait("xfa_imm5257e.pdf", ".xfaLayer");
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must search xfa correctly", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
await page.click("#viewFindButton");
|
|
await page.waitForSelector("#viewFindButton", { hidden: false });
|
|
await page.type("#findInput", "preferences");
|
|
await page.waitForSelector("#findInput[data-status='']");
|
|
await page.waitForSelector(".xfaLayer .highlight");
|
|
await page.waitForFunction(
|
|
() => !!document.querySelector("#findResultsCount")?.textContent
|
|
);
|
|
const resultElement = await page.waitForSelector("#findResultsCount");
|
|
const resultText = await resultElement.evaluate(el => el.textContent);
|
|
/** Unicode bidi isolation characters. */
|
|
const FSI = "\u2068";
|
|
const PDI = "\u2069";
|
|
// Fluent adds these markers to the result text.
|
|
expect(resultText).toEqual(`${FSI}1${PDI} of ${FSI}1${PDI} match`);
|
|
const selectedElement = await page.waitForSelector(
|
|
".highlight.selected"
|
|
);
|
|
const selectedText = await selectedElement.evaluate(
|
|
el => el.textContent
|
|
);
|
|
expect(selectedText).toEqual("Preferences");
|
|
})
|
|
);
|
|
});
|
|
});
|
|
});
|