After clicking the find button we need to wait for the input field to appear before we try to type in it, but instead we were waiting for the button to appear. However, the button is always present, so the current `waitForSelector` call is basically a no-op, and this can cause the integration tests to fail intermittently if we continue before the input field is actually visible. This appears to be due a typo first introduced in commit d10da907dac86c103b787127110a59aed82c7aaa that has been copy/pasted. This commit fixes the issue by waiting for the input field to be visible before we continue typing in it.
153 lines
5.7 KiB
JavaScript
153 lines
5.7 KiB
JavaScript
/* Copyright 2021 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { closePages, FSI, loadAndWait, PDI } from "./test_utils.mjs";
|
|
|
|
function fuzzyMatch(a, b, browserName, pixelFuzz = 3) {
|
|
expect(a)
|
|
.withContext(`In ${browserName}`)
|
|
.toBeLessThan(b + pixelFuzz);
|
|
expect(a)
|
|
.withContext(`In ${browserName}`)
|
|
.toBeGreaterThan(b - pixelFuzz);
|
|
}
|
|
|
|
describe("find bar", () => {
|
|
describe("highlight all", () => {
|
|
let pages;
|
|
|
|
beforeEach(async () => {
|
|
pages = await loadAndWait("find_all.pdf", ".textLayer", 100);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must highlight text in the right position", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
// Highlight all occurrences of the letter A (case insensitive).
|
|
await page.click("#viewFindButton");
|
|
await page.waitForSelector("#findInput", { visible: true });
|
|
await page.type("#findInput", "a");
|
|
await page.click("#findHighlightAll + label");
|
|
await page.waitForSelector(".textLayer .highlight");
|
|
|
|
// The PDF file contains the text 'AB BA' in a monospace font on a
|
|
// single line. Check if the two occurrences of A are highlighted.
|
|
const highlights = await page.$$(".textLayer .highlight");
|
|
expect(highlights.length).withContext(`In ${browserName}`).toEqual(2);
|
|
|
|
// Normalize the highlight's height. The font data in the PDF sets the
|
|
// size of the glyphs (and therefore the size of the highlights), but
|
|
// the viewer applies extra padding to them. For the comparison we
|
|
// therefore use the unpadded, glyph-sized parent element's height.
|
|
const parentSpan = (await highlights[0].$$("xpath/.."))[0];
|
|
const parentBox = await parentSpan.boundingBox();
|
|
const firstA = await highlights[0].boundingBox();
|
|
const secondA = await highlights[1].boundingBox();
|
|
firstA.height = parentBox.height;
|
|
secondA.height = parentBox.height;
|
|
|
|
// Check if the vertical position of the highlights is correct. Both
|
|
// should be on a single line.
|
|
expect(firstA.y).withContext(`In ${browserName}`).toEqual(secondA.y);
|
|
|
|
// Check if the height of the two highlights is correct. Both should
|
|
// match the font size.
|
|
const fontSize = 26.66; // From the PDF.
|
|
fuzzyMatch(firstA.height, fontSize, browserName);
|
|
fuzzyMatch(secondA.height, fontSize, browserName);
|
|
|
|
// Check if the horizontal position of the highlights is correct. The
|
|
// second occurrence should be four glyph widths (three letters and
|
|
// one space) away from the first occurrence.
|
|
const pageDiv = await page.$(".page canvas");
|
|
const pageBox = await pageDiv.boundingBox();
|
|
const expectedFirstAX = 30; // From the PDF.
|
|
const glyphWidth = 15.98; // From the PDF.
|
|
fuzzyMatch(firstA.x, pageBox.x + expectedFirstAX, browserName);
|
|
fuzzyMatch(secondA.x, firstA.x + glyphWidth * 4, browserName);
|
|
})
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("highlight all (XFA)", () => {
|
|
let pages;
|
|
|
|
beforeEach(async () => {
|
|
pages = await loadAndWait("xfa_imm5257e.pdf", ".xfaLayer");
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must search xfa correctly", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
await page.click("#viewFindButton");
|
|
await page.waitForSelector("#findInput", { visible: true });
|
|
await page.type("#findInput", "preferences");
|
|
await page.waitForSelector("#findInput[data-status='']");
|
|
await page.waitForSelector(".xfaLayer .highlight");
|
|
await page.waitForFunction(
|
|
() => !!document.querySelector("#findResultsCount")?.textContent
|
|
);
|
|
const resultElement = await page.waitForSelector("#findResultsCount");
|
|
const resultText = await resultElement.evaluate(el => el.textContent);
|
|
expect(resultText).toEqual(`${FSI}1${PDI} of ${FSI}1${PDI} match`);
|
|
const selectedElement = await page.waitForSelector(
|
|
".highlight.selected"
|
|
);
|
|
const selectedText = await selectedElement.evaluate(
|
|
el => el.textContent
|
|
);
|
|
expect(selectedText).toEqual("Preferences");
|
|
})
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("issue19207.pdf", () => {
|
|
let pages;
|
|
|
|
beforeEach(async () => {
|
|
pages = await loadAndWait("issue19207.pdf", ".textLayer", 200);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must scroll to the search result text", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
// Search for "40"
|
|
await page.click("#viewFindButton");
|
|
await page.waitForSelector("#findInput", { visible: true });
|
|
await page.type("#findInput", "40");
|
|
|
|
const highlight = await page.waitForSelector(".textLayer .highlight");
|
|
|
|
expect(await highlight.isIntersectingViewport()).toBeTrue();
|
|
})
|
|
);
|
|
});
|
|
});
|
|
});
|