37ef0b4a86
*Note:* For the issue mentioned on Matrix it'll obviously still make sense to improve the regular expression to detect more URL edge-cases. However it occurred to me that even once that particular case is fixed there'll always be a risk that inferred links could overlap, and effectively block, the actual LinkAnnotations. Hence this patch removes the URL comparison to ensure that overlapping inferred links will always be ignored.
125 lines
3.5 KiB
JavaScript
125 lines
3.5 KiB
JavaScript
/* Copyright 2025 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { closePages, loadAndWait } from "./test_utils.mjs";
|
|
|
|
describe("autolinker", function () {
|
|
describe("bug1019475_2.pdf", function () {
|
|
let pages;
|
|
|
|
beforeAll(async () => {
|
|
pages = await loadAndWait(
|
|
"bug1019475_2.pdf",
|
|
".annotationLayer",
|
|
null,
|
|
null,
|
|
{
|
|
enableAutoLinking: true,
|
|
}
|
|
);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must appropriately add link annotations when relevant", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
const url = await page.$$eval(
|
|
".annotationLayer > .linkAnnotation > a",
|
|
annotations => annotations.map(a => a.href)
|
|
);
|
|
expect(url.length).withContext(`In ${browserName}`).toEqual(1);
|
|
expect(url[0])
|
|
.withContext(`In ${browserName}`)
|
|
.toEqual("http://www.mozilla.org/");
|
|
})
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("bug1019475_1.pdf", function () {
|
|
let pages;
|
|
|
|
beforeAll(async () => {
|
|
pages = await loadAndWait(
|
|
"bug1019475_1.pdf",
|
|
".annotationLayer",
|
|
null,
|
|
null,
|
|
{
|
|
enableAutoLinking: true,
|
|
}
|
|
);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must not add links when unnecessary", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
const linkIds = await page.$$eval(
|
|
".annotationLayer > .linkAnnotation > a",
|
|
annotations =>
|
|
annotations.map(a => a.getAttribute("data-element-id"))
|
|
);
|
|
expect(linkIds.length).withContext(`In ${browserName}`).toEqual(3);
|
|
linkIds.forEach(id =>
|
|
expect(id)
|
|
.withContext(`In ${browserName}`)
|
|
.not.toContain("inferred_link_")
|
|
);
|
|
})
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("pr19449.pdf", function () {
|
|
let pages;
|
|
|
|
beforeAll(async () => {
|
|
pages = await loadAndWait("pr19449.pdf", ".annotationLayer", null, null, {
|
|
docBaseUrl: "http://example.com",
|
|
enableAutoLinking: true,
|
|
});
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must not add links that overlap even if the URLs are different", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
const linkIds = await page.$$eval(
|
|
".annotationLayer > .linkAnnotation > a",
|
|
annotations =>
|
|
annotations.map(a => a.getAttribute("data-element-id"))
|
|
);
|
|
expect(linkIds.length).withContext(`In ${browserName}`).toEqual(1);
|
|
linkIds.forEach(id =>
|
|
expect(id)
|
|
.withContext(`In ${browserName}`)
|
|
.not.toContain("inferred_link_")
|
|
);
|
|
})
|
|
);
|
|
});
|
|
});
|
|
});
|