revert using null keyword

env.DOCKERHUB_USERNAME shouldn't be an empty string as it's defined and set (I think, I can't see this). Even if wasn't defined, GitHub Org/Repo wide envs/secrets should return an empty string (?)
This commit is contained in:
Ivan Gabaldon 2025-05-11 18:39:25 +02:00
parent d16854e67a
commit 235ed8f0f2
No known key found for this signature in database
GPG Key ID: 075587C93FA67582

View File

@ -153,13 +153,13 @@ jobs:
- test - test
steps: steps:
- if: env.DOCKERHUB_USERNAME != '' - if: env.DOCKERHUB_USERNAME != null
name: Checkout name: Checkout
uses: actions/checkout@v4 uses: actions/checkout@v4
with: with:
persist-credentials: "false" persist-credentials: "false"
- if: env.DOCKERHUB_USERNAME != '' - if: env.DOCKERHUB_USERNAME != null
name: Login to GHCR name: Login to GHCR
uses: docker/login-action@v3 uses: docker/login-action@v3
with: with:
@ -167,7 +167,7 @@ jobs:
username: "${{ github.repository_owner }}" username: "${{ github.repository_owner }}"
password: "${{ secrets.GITHUB_TOKEN }}" password: "${{ secrets.GITHUB_TOKEN }}"
- if: env.DOCKERHUB_USERNAME != '' - if: env.DOCKERHUB_USERNAME != null
name: Login to Docker Hub name: Login to Docker Hub
uses: docker/login-action@v3 uses: docker/login-action@v3
with: with:
@ -175,7 +175,7 @@ jobs:
username: "${{ env.DOCKERHUB_USERNAME }}" username: "${{ env.DOCKERHUB_USERNAME }}"
password: "${{ secrets.DOCKERHUB_TOKEN }}" password: "${{ secrets.DOCKERHUB_TOKEN }}"
- if: env.DOCKERHUB_USERNAME != '' - if: env.DOCKERHUB_USERNAME != null
name: Release name: Release
env: env:
GIT_URL: "${{ needs.build.outputs.git_url }}" GIT_URL: "${{ needs.build.outputs.git_url }}"