From 523d2a76837cc8e94f29afc490c312e6af8398a7 Mon Sep 17 00:00:00 2001 From: Markus Heiser Date: Thu, 6 Mar 2025 08:50:30 +0100 Subject: [PATCH] [fix] uwsgi: don't set static-expires As long we don't have a working solution for cache busting [3][4] we should not set an expire time in thw uWSGI config. The default procedure in every web browser is the "304 Not Modified" [2] and this default procedure should also be sufficient for us as long as we have not implemented a complete alternative (cache busting) / form [1] > By default uWSGI will add a Last-Modified [2] header to all static responses, > and will honor the If-Modified-Since [2] request header. [1] https://uwsgi-docs.readthedocs.io/en/latest/StaticFiles.html#setting-the-expires-headers [2] https://developer.mozilla.org/de/docs/Web/HTTP/Status/304 [3] https://github.com/searxng/searxng/pull/4433 [4] https://github.com/searxng/searxng/issues/964 Signed-off-by: Markus Heiser --- dockerfiles/uwsgi.ini | 1 - utils/templates/etc/uwsgi/apps-archlinux/searxng.ini | 2 -- utils/templates/etc/uwsgi/apps-archlinux/searxng.ini:socket | 2 -- utils/templates/etc/uwsgi/apps-available/searxng.ini | 2 -- utils/templates/etc/uwsgi/apps-available/searxng.ini:socket | 2 -- 5 files changed, 9 deletions(-) diff --git a/dockerfiles/uwsgi.ini b/dockerfiles/uwsgi.ini index 812716853..abe552274 100644 --- a/dockerfiles/uwsgi.ini +++ b/dockerfiles/uwsgi.ini @@ -49,6 +49,5 @@ die-on-term # uwsgi serves the static files static-map = /static=/usr/local/searxng/searx/static # expires set to one day -static-expires = /* 86400 static-gzip-all = True offload-threads = %k diff --git a/utils/templates/etc/uwsgi/apps-archlinux/searxng.ini b/utils/templates/etc/uwsgi/apps-archlinux/searxng.ini index 650c8cc3f..12543cf5b 100644 --- a/utils/templates/etc/uwsgi/apps-archlinux/searxng.ini +++ b/utils/templates/etc/uwsgi/apps-archlinux/searxng.ini @@ -81,7 +81,5 @@ buffer-size = 8192 # static_use_hash: true # static-map = /static=${SEARXNG_STATIC} -# expires set to one day -static-expires = /* 86400 static-gzip-all = True offload-threads = %k diff --git a/utils/templates/etc/uwsgi/apps-archlinux/searxng.ini:socket b/utils/templates/etc/uwsgi/apps-archlinux/searxng.ini:socket index eb1220233..0e6a7529d 100644 --- a/utils/templates/etc/uwsgi/apps-archlinux/searxng.ini:socket +++ b/utils/templates/etc/uwsgi/apps-archlinux/searxng.ini:socket @@ -78,7 +78,5 @@ buffer-size = 8192 # static_use_hash: true # static-map = /static=${SEARXNG_STATIC} -# expires set to one day -static-expires = /* 86400 static-gzip-all = True offload-threads = %k diff --git a/utils/templates/etc/uwsgi/apps-available/searxng.ini b/utils/templates/etc/uwsgi/apps-available/searxng.ini index 7d367d9ee..9887d7909 100644 --- a/utils/templates/etc/uwsgi/apps-available/searxng.ini +++ b/utils/templates/etc/uwsgi/apps-available/searxng.ini @@ -84,7 +84,5 @@ buffer-size = 8192 # static_use_hash: true # static-map = /static=${SEARXNG_STATIC} -# expires set to one day -static-expires = /* 86400 static-gzip-all = True offload-threads = %k diff --git a/utils/templates/etc/uwsgi/apps-available/searxng.ini:socket b/utils/templates/etc/uwsgi/apps-available/searxng.ini:socket index 2f95fab7c..9e2cfc273 100644 --- a/utils/templates/etc/uwsgi/apps-available/searxng.ini:socket +++ b/utils/templates/etc/uwsgi/apps-available/searxng.ini:socket @@ -81,7 +81,5 @@ buffer-size = 8192 # static_use_hash: true # static-map = /static=${SEARXNG_STATIC} -# expires set to one day -static-expires = /* 86400 static-gzip-all = True offload-threads = %k