Beanz/searxng
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[fix] engine dokuwiki: basedir duplication

Browse Source 
Dokuwiki searches behind reverse proxy had duplicate base path in the url,
creating a wrong url.

This patch exchanges string concat of URLs with urljoin [1] from urllib.parse.  This
eliminates the dual problem, while retaining the old functionality designed to
concatenate protocol, hostname and port (as base_url) with path.

[1] https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urljoin

Closes: https://github.com/searxng/searxng/issues/4598
This commit is contained in:
grasdk 2025-04-11 00:24:10 +02:00 committed by Markus Heiser
parent ed2953c59f
commit 8ee51cc0f3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
searx/engines/doku.py
View File

@ -4,6 +4,7 @@
""" """
from urllib.parse import urlencode from urllib.parse import urlencode
from urllib.parse import urljoin
from lxml.html import fromstring from lxml.html import fromstring
from searx.utils import extract_text, eval_xpath from searx.utils import extract_text, eval_xpath
@ -63,7 +64,7 @@ def response(resp):
title = extract_text(eval_xpath(r, './/a[@class="wikilink1"]/@title')) title = extract_text(eval_xpath(r, './/a[@class="wikilink1"]/@title'))
# append result # append result
results.append({'title': title, 'content': "", 'url': base_url + res_url}) results.append({'title': title, 'content': "", 'url': urljoin(base_url, res_url)})
# Search results # Search results
for r in eval_xpath(doc, '//dl[@class="search_results"]/*'): for r in eval_xpath(doc, '//dl[@class="search_results"]/*'):
@ -75,7 +76,7 @@ def response(resp):
content = extract_text(eval_xpath(r, '.')) content = extract_text(eval_xpath(r, '.'))
# append result # append result
results.append({'title': title, 'content': content, 'url': base_url + res_url}) results.append({'title': title, 'content': content, 'url': urljoin(base_url, res_url)})
except: # pylint: disable=bare-except except: # pylint: disable=bare-except
continue continue